From dfc46f02681447370a1ccbe340034e970bc7e572 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 5 Sep 2021 08:37:27 -0700 Subject: [PATCH] [clang-tidy] Drop unnecessary const from return types (NFC) Identified with readability-const-return-type. --- .../cppcoreguidelines/PreferMemberInitializerCheck.cpp | 2 +- .../clang-tidy/readability/IdentifierNamingCheck.cpp | 2 +- .../clang-tidy/readability/IdentifierNamingCheck.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp b/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp index 9ff94a009d0d..169b828a3c92 100644 --- a/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp +++ b/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp @@ -83,7 +83,7 @@ static bool isSafeAssignment(const FieldDecl *Field, const Expr *Init, .empty(); } -static const std::pair +static std::pair isAssignmentToMemberOf(const CXXRecordDecl *Rec, const Stmt *S, const CXXConstructorDecl *Ctor) { if (const auto *BO = dyn_cast(S)) { diff --git a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp index 5126d76a2268..0ff0708adc4a 100644 --- a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp @@ -534,7 +534,7 @@ bool IdentifierNamingCheck::HungarianNotation::removeDuplicatedPrefix( return false; } -const std::string IdentifierNamingCheck::HungarianNotation::getDataTypePrefix( +std::string IdentifierNamingCheck::HungarianNotation::getDataTypePrefix( StringRef TypeName, const NamedDecl *ND, const IdentifierNamingCheck::HungarianNotationOption &HNOption) const { if (!ND || TypeName.empty()) diff --git a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h index ac8cfc8b4d51..da303d785b8a 100644 --- a/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h +++ b/clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h @@ -109,7 +109,7 @@ public: const Decl *D, const IdentifierNamingCheck::HungarianNotationOption &HNOption) const; - const std::string getDataTypePrefix( + std::string getDataTypePrefix( StringRef TypeName, const NamedDecl *ND, const IdentifierNamingCheck::HungarianNotationOption &HNOption) const;