maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[flang] [OpenMP] avoid creating new symbol for common block 

Original-commit: flang-compiler/f18@ba2cceb4a2
This commit is contained in:
Jinxin Yang 2019-09-16 21:26:40 -07:00 committed by Jinxin (Brian) Yang
parent f3961579ac
commit df51352d72
2 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
flang/lib/semantics/resolve-names.cc
View File

@ -1096,25 +1096,17 @@ protected:
void ResolveOmpObject(const parser::OmpObject &, Symbol::Flag);
Symbol *ResolveOmp(const parser::Name &, Symbol::Flag);
Symbol *ResolveOmp(Symbol &, Symbol::Flag);
Symbol *ResolveOmpCommonBlockName(const parser::Name *, Symbol::Flag);
Symbol *ResolveOmpCommonBlockName(const parser::Name *);
Symbol *DeclarePrivateAccessEntity(const parser::Name &, Symbol::Flag);
Symbol *DeclarePrivateAccessEntity(Symbol &, Symbol::Flag);
Symbol *DeclareOrMarkOtherAccessEntity(const parser::Name &, Symbol::Flag);
Symbol *DeclareOrMarkOtherAccessEntity(Symbol &, Symbol::Flag);
};
Symbol *OmpVisitor::ResolveOmpCommonBlockName(
const parser::Name *name, Symbol::Flag ompFlag) {
Symbol *OmpVisitor::ResolveOmpCommonBlockName(const parser::Name *name) {
if (auto *prev{name ? currScope().parent().FindCommonBlock(name->source)
: nullptr}) {
auto *created{FindInScope(currScope(), name->source)};
if (!created) {
auto &symbol{MakeSymbol(*name, HostAssocDetails{*prev})};
symbol.set(ompFlag);
name->symbol = &symbol;
} else {
name->symbol = created;
}
name->symbol = prev;
return prev;
} else {
return nullptr;
@ -1152,7 +1144,7 @@ void OmpVisitor::ResolveOmpObject(
}
}
} else { // common block
if (auto *symbol{ResolveOmpCommonBlockName(name, ompFlag)}) {
if (auto *symbol{ResolveOmpCommonBlockName(name)}) {
// 2.15.3 When a named common block appears in a list, it has the same
// meaning as if every explicit member of the common block appeared in
// the list

4
flang/test/semantics/omp-symbol01.f90
View File

@ -58,7 +58,7 @@ program mm
a = 1.0
!DEF: /mm/c (Implicit) ObjectEntity REAL(4)
c = 2.0
!$omp parallel do private(a,t,/c/)
!$omp parallel do private(a,t,/c/) shared(c)
!DEF: /mm/i (Implicit) ObjectEntity INTEGER(4)
do i=1,10
!DEF: /mm/Block1/a (OmpPrivate) HostAssoc REAL(4)
@ -76,5 +76,7 @@ program mm
!REF: /mm/i
!REF: /mm/Block1/y
x = a+i+y
!REF: /mm/c
c = 3.0
end do
end program