diff --git a/clang/lib/Driver/ToolChains/Arch/X86.cpp b/clang/lib/Driver/ToolChains/Arch/X86.cpp index bfa008f964e1..2e43c455b28f 100644 --- a/clang/lib/Driver/ToolChains/Arch/X86.cpp +++ b/clang/lib/Driver/ToolChains/Arch/X86.cpp @@ -59,8 +59,9 @@ std::string x86::getX86TargetCPU(const Driver &D, const ArgList &Args, } StringRef CPU = ArchMap.lookup(A->getValue()); if (CPU.empty()) { - std::vector ValidArchs{ArchMap.keys().begin(), - ArchMap.keys().end()}; + std::vector ValidArchs; + for (StringRef Key : ArchMap.keys()) + ValidArchs.push_back(Key); sort(ValidArchs); D.Diag(diag::warn_drv_invalid_arch_name_with_suggestion) << A->getValue() << (Triple.getArch() == llvm::Triple::x86) diff --git a/llvm/include/llvm/ADT/StringMap.h b/llvm/include/llvm/ADT/StringMap.h index fa99ecd81106..003e62d98ec2 100644 --- a/llvm/include/llvm/ADT/StringMap.h +++ b/llvm/include/llvm/ADT/StringMap.h @@ -478,9 +478,13 @@ public: explicit StringMapKeyIterator(StringMapConstIterator Iter) : base(std::move(Iter)) {} - StringRef operator*() const { - return this->wrapped()->getKey(); + StringRef &operator*() { + Key = this->wrapped()->getKey(); + return Key; } + +private: + StringRef Key; }; } // end namespace llvm diff --git a/llvm/unittests/ADT/StringMapTest.cpp b/llvm/unittests/ADT/StringMapTest.cpp index f38a60452e3c..6a3cca5a4a32 100644 --- a/llvm/unittests/ADT/StringMapTest.cpp +++ b/llvm/unittests/ADT/StringMapTest.cpp @@ -308,21 +308,7 @@ TEST_F(StringMapTest, InsertOrAssignTest) { EXPECT_EQ(0, try1.first->second.copy); } -TEST_F(StringMapTest, IterMapKeysVector) { - StringMap Map; - Map["A"] = 1; - Map["B"] = 2; - Map["C"] = 3; - Map["D"] = 3; - - std::vector Keys{Map.keys().begin(), Map.keys().end()}; - llvm::sort(Keys); - - std::vector Expected{{"A", "B", "C", "D"}}; - EXPECT_EQ(Expected, Keys); -} - -TEST_F(StringMapTest, IterMapKeysSmallVector) { +TEST_F(StringMapTest, IterMapKeys) { StringMap Map; Map["A"] = 1; Map["B"] = 2;