maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Sanitizer] Fix uses of stack->Unwind(..., fast) 

Apply StackTrace::WillUseFastUnwind(fast) in a few more places missed by
my previous patch (https://reviews.llvm.org/D58156).

Reviewers: vitalybuka

Differential Revision: https://reviews.llvm.org/D58550

llvm-svn: 354695
This commit is contained in:
Julian Lettner 2019-02-22 22:00:13 +00:00
parent ffba00bd47
commit de7626985f
4 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cc
View File

@ -103,7 +103,7 @@ void ReportMmapWriteExec(int prot) {
GET_CALLER_PC_BP_SP; GET_CALLER_PC_BP_SP;
(void)sp; (void)sp;
bool fast = common_flags()->fast_unwind_on_fatal; bool fast = common_flags()->fast_unwind_on_fatal;
if (fast) if (StackTrace::WillUseFastUnwind(fast))
GetThreadStackTopAndBottom(false, &top, &bottom); GetThreadStackTopAndBottom(false, &top, &bottom);
stack->Unwind(kStackTraceMax, pc, bp, nullptr, top, bottom, fast); stack->Unwind(kStackTraceMax, pc, bp, nullptr, top, bottom, fast);

3
compiler-rt/lib/tsan/rtl/tsan_rtl.cc
View File

@ -331,7 +331,8 @@ static void OnStackUnwind(const SignalContext &sig, const void *,
uptr top = 0; uptr top = 0;
uptr bottom = 0; uptr bottom = 0;
bool fast = common_flags()->fast_unwind_on_fatal; bool fast = common_flags()->fast_unwind_on_fatal;
if (fast) GetThreadStackTopAndBottom(false, &top, &bottom); if (StackTrace::WillUseFastUnwind(fast))
GetThreadStackTopAndBottom(false, &top, &bottom);
stack->Unwind(kStackTraceMax, sig.pc, sig.bp, sig.context, top, bottom, fast); stack->Unwind(kStackTraceMax, sig.pc, sig.bp, sig.context, top, bottom, fast);
} }

2
compiler-rt/lib/ubsan/ubsan_diag.cc
View File

@ -30,7 +30,7 @@ void __ubsan::GetStackTrace(BufferedStackTrace *stack, uptr max_depth, uptr pc,
uptr bp, void *context, bool fast) { uptr bp, void *context, bool fast) {
uptr top = 0; uptr top = 0;
uptr bottom = 0; uptr bottom = 0;
if (fast) if (StackTrace::WillUseFastUnwind(fast))
GetThreadStackTopAndBottom(false, &top, &bottom); GetThreadStackTopAndBottom(false, &top, &bottom);
stack->Unwind(max_depth, pc, bp, context, top, bottom, fast); stack->Unwind(max_depth, pc, bp, context, top, bottom, fast);
} }

4
compiler-rt/test/sanitizer_common/TestCases/Posix/dedup_token_length_test.cc
View File

@ -10,8 +10,8 @@
// XFAIL: netbsd && !asan // XFAIL: netbsd && !asan
// FIXME(dliew): Make this test work with other sanitizers // FIXME(dliew): Make this test work with TSan
// XFAIL: darwin && (tsan || ubsan) // XFAIL: darwin && tsan
volatile int *null = 0; volatile int *null = 0;