[llvm-cov] Move a check into a helper method (NFC)

llvm-svn: 274025

llvm/tools/llvm-cov/CoverageViewOptions.h

@@ -37,6 +37,9 @@ struct CoverageViewOptions {
                                     raw_ostream::Colors Color) const {
     return llvm::colored_ostream(OS, Color, Colors);
   }
+
+  /// \brief Check if an output directory has been specified.
+  bool hasOutputDirectory() const { return ShowOutputDirectory != ""; }
 };
 }
 

llvm/tools/llvm-cov/SourceCoverageView.cpp

@@ -74,7 +74,7 @@ Expected<SourceCoverageView::OwnedStream>
 SourceCoverageView::createOutputStream(const CoverageViewOptions &Opts,
                                        StringRef Path, StringRef Extension,
                                        bool InToplevel) {
-  if (Opts.ShowOutputDirectory == "")
+  if (!Opts.hasOutputDirectory())
     return OwnedStream(&outs());
 
   return createFileInDirectory(Opts.ShowOutputDirectory,