maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[flang] Add missing source location to a semantic error message 

Ensure that the semantic error "An allocatable or pointer component
reference must be applied to a scalar base" is emitted with a source
code location.

Differential Revision: https://reviews.llvm.org/D135215
This commit is contained in:
Peter Klausler 2022-10-04 12:41:48 -07:00
parent aa065c016b
commit ddb35533e6
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
flang/lib/Semantics/expression.cpp
View File

@ -1145,6 +1145,7 @@ MaybeExpr ExpressionAnalyzer::Analyze(const parser::StructureComponent &sc) {
return std::nullopt;
} else if (std::optional<DataRef> dataRef{
ExtractDataRef(std::move(*dtExpr))}) {
auto restorer{GetContextualMessages().SetLocation(name)};
if (auto component{
CreateComponent(std::move(*dataRef), *sym, *dtSpec->scope())}) {
return Designate(DataRef{std::move(*component)});

15
flang/test/Semantics/expr-errors04.f90
View File

@ -14,6 +14,8 @@ program m
complex :: c, c2(2)
integer :: x, x2(2)
character(10) :: s, s2(2)
real, pointer :: p
real, allocatable :: a
contains
procedure, nopass :: info1 => real_info1
procedure, nopass :: info2 => real_info2
@ -108,4 +110,17 @@ program m
!ERROR: Reference to rank-2 object 't1' has 1 subscripts
call t%t3%t2%t1(1:)%g1
!ERROR: An allocatable or pointer component reference must be applied to a scalar base
print *, t(1)%t3(1)%t2(1)%t1%p
!ERROR: An allocatable or pointer component reference must be applied to a scalar base
print *, t%t3(1)%t2(1)%t1(1,1)%p
!ERROR: An allocatable or pointer component reference must be applied to a scalar base
print *, t(1)%t3(1)%t2(1)%t1%a
!ERROR: An allocatable or pointer component reference must be applied to a scalar base
print *, t%t3(1)%t2(1)%t1(1,1)%a
!ERROR: An allocatable or pointer component reference must be applied to a scalar base
t(1)%t3(1)%t2(1)%t1%p => null()
!ERROR: An allocatable or pointer component reference must be applied to a scalar base
t%t3(1)%t2(1)%t1(1,1)%p => null()
end