maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[PhiValues] Use SetVector to avoid non-determinism 

I'm not sure whether this can cause actual non-determinism in the
compiler output, but at least it causes non-determinism in the
statistics collected by BasicAA.

Use SetVector to have a predictable iteration order.
This commit is contained in:
Nikita Popov 2020-10-22 23:49:08 +02:00
parent 1253c40727
commit dd887d97ce
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/include/llvm/Analysis/PhiValues.h
View File

@ -21,7 +21,7 @@
#include "llvm/ADT/DenseMap.h" #include "llvm/ADT/DenseMap.h"
#include "llvm/ADT/DenseSet.h" #include "llvm/ADT/DenseSet.h"
#include "llvm/ADT/SmallPtrSet.h" #include "llvm/ADT/SetVector.h"
#include "llvm/ADT/SmallVector.h" #include "llvm/ADT/SmallVector.h"
#include "llvm/IR/PassManager.h" #include "llvm/IR/PassManager.h"
#include "llvm/IR/ValueHandle.h" #include "llvm/IR/ValueHandle.h"
@ -40,7 +40,7 @@ class Function;
/// it is queried. /// it is queried.
class PhiValues { class PhiValues {
public: public:
using ValueSet = SmallPtrSet<Value *, 4>; using ValueSet = SmallSetVector<Value *, 4>;
/// Construct an empty PhiValues. /// Construct an empty PhiValues.
PhiValues(const Function &F) : F(F) {} PhiValues(const Function &F) : F(F) {}
@ -70,8 +70,7 @@ public:
FunctionAnalysisManager::Invalidator &); FunctionAnalysisManager::Invalidator &);
private: private:
using PhiSet = SmallPtrSet<const PHINode *, 4>; using ConstValueSet = SmallSetVector<const Value *, 4>;
using ConstValueSet = SmallPtrSet<const Value *, 4>;
/// The next depth number to be used by processPhi. /// The next depth number to be used by processPhi.
unsigned int NextDepthNumber = 1; unsigned int NextDepthNumber = 1;

1
llvm/lib/Analysis/PhiValues.cpp
View File

@ -7,7 +7,6 @@
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "llvm/Analysis/PhiValues.h" #include "llvm/Analysis/PhiValues.h"
#include "llvm/ADT/SmallPtrSet.h"
#include "llvm/ADT/SmallVector.h" #include "llvm/ADT/SmallVector.h"
#include "llvm/IR/Instructions.h" #include "llvm/IR/Instructions.h"
#include "llvm/InitializePasses.h" #include "llvm/InitializePasses.h"