From dd5a59baedc99d2c2058b6c3b59f7860e45cdcc5 Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Fri, 24 Feb 2012 17:35:35 +0000 Subject: [PATCH] objc modern translator. Fixes writing of block pointer ivar access. llvm-svn: 151371 --- clang/lib/Rewrite/RewriteModernObjC.cpp | 4 +++- .../Rewriter/rewrite-modern-block-ivar-call.mm | 17 +++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 clang/test/Rewriter/rewrite-modern-block-ivar-call.mm diff --git a/clang/lib/Rewrite/RewriteModernObjC.cpp b/clang/lib/Rewrite/RewriteModernObjC.cpp index 63dfa561d3af..403ccd9c12d5 100644 --- a/clang/lib/Rewrite/RewriteModernObjC.cpp +++ b/clang/lib/Rewrite/RewriteModernObjC.cpp @@ -6469,8 +6469,10 @@ Stmt *RewriteModernObjC::RewriteObjCIvarRefExpr(ObjCIvarRefExpr *IV) { ParenExpr *PE = new (Context) ParenExpr(SourceLocation(), SourceLocation(), addExpr); + QualType IvarT = D->getType(); + convertBlockPointerToFunctionPointer(IvarT); + QualType castT = Context->getPointerType(IvarT); - QualType castT = Context->getPointerType(D->getType()); castExpr = NoTypeInfoCStyleCastExpr(Context, castT, CK_BitCast, diff --git a/clang/test/Rewriter/rewrite-modern-block-ivar-call.mm b/clang/test/Rewriter/rewrite-modern-block-ivar-call.mm new file mode 100644 index 000000000000..0fe2d543ee00 --- /dev/null +++ b/clang/test/Rewriter/rewrite-modern-block-ivar-call.mm @@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -E %s -o %t.m +// RUN: %clang_cc1 -fblocks -rewrite-objc -fms-extensions %t.m -o %t-rw.cpp +// RUN: FileCheck --input-file=%t-rw.cpp %s +// RUN: %clang_cc1 -fsyntax-only -Wno-address-of-temporary -D"Class=void*" -D"id=void*" -D"SEL=void*" -D"__declspec(X)=" %t-rw.cpp + +@interface Foo { + void (^_block)(void); +} +@end + +@implementation Foo +- (void)bar { + _block(); +} +@end + +// CHECK: ((void (*)(struct __block_impl *))((struct __block_impl *)(*(void (**)(void))((char *)self + OBJC_IVAR_$_Foo__block)))->FuncPtr)((struct __block_impl *)(*(void (**)(void))((char *)self + OBJC_IVAR_$_Foo__block)));