forked from OSchip/llvm-project
Delete the copy constructor for llvm::yaml::Node
The nodes keep a reference back to the original document, but the document is streamed, not read all into memory at once, and the position is part of the state. If nodes are ever copied, the document position can end up being advanced more than once. This did not reveal any problems in LLVM or Clang but caught a handful over in Swift! llvm-svn: 328345
This commit is contained in:
parent
80f10e4fe5
commit
dc86de6b6e
|
@ -125,6 +125,11 @@ public:
|
|||
Node(unsigned int Type, std::unique_ptr<Document> &, StringRef Anchor,
|
||||
StringRef Tag);
|
||||
|
||||
// It's not safe to copy YAML nodes; the document is streamed and the position
|
||||
// is part of the state.
|
||||
Node(const Node &) = delete;
|
||||
void operator=(const Node &) = delete;
|
||||
|
||||
void *operator new(size_t Size, BumpPtrAllocator &Alloc,
|
||||
size_t Alignment = 16) noexcept {
|
||||
return Alloc.Allocate(Size, Alignment);
|
||||
|
|
Loading…
Reference in New Issue