maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

A quoted - is not the beginning of an option, and should not be completed as such. This was causing: 

(lldb) disassemble -n '-<TAB>

to crash.

<rdar://problem/18134531>

llvm-svn: 216626
This commit is contained in:
Jim Ingham 2014-08-27 22:06:58 +00:00
parent 4eb1b271fc
commit dc498e516f
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/source/Interpreter/Args.cpp
View File

@ -1644,8 +1644,10 @@ Args::ParseArgsForCompletion
// Finally we have to handle the case where the cursor index points at a single "-". We want to mark that in // Finally we have to handle the case where the cursor index points at a single "-". We want to mark that in
// the option_element_vector, but only if it is not after the "--". But it turns out that OptionParser::Parse just ignores // the option_element_vector, but only if it is not after the "--". But it turns out that OptionParser::Parse just ignores
// an isolated "-". So we have to look it up by hand here. We only care if it is AT the cursor position. // an isolated "-". So we have to look it up by hand here. We only care if it is AT the cursor position.
// Note, a single quoted dash is not the same as a single dash...
if ((static_cast<int32_t>(dash_dash_pos) == -1 || cursor_index < dash_dash_pos) if ((static_cast<int32_t>(dash_dash_pos) == -1 || cursor_index < dash_dash_pos)
&& m_args_quote_char[cursor_index] == '\0'
&& strcmp (GetArgumentAtIndex(cursor_index), "-") == 0) && strcmp (GetArgumentAtIndex(cursor_index), "-") == 0)
{ {
option_element_vector.push_back (OptionArgElement (OptionArgElement::eBareDash, cursor_index, option_element_vector.push_back (OptionArgElement (OptionArgElement::eBareDash, cursor_index,