maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] Possibility of displaying duplicate warnings 

Summary: In case a checker is registered multiple times as an alias, the emitted warnings are uniqued by the report message. However, it is random which checker name is included in the warning. When processing the output of clang-tidy this behavior caused some problems. In this commit the uniquing key contains the checker name too.

Reviewers: alexfh, xazax.hun, Szelethus, aaron.ballman, lebedev.ri, JonasToth, gribozavr

Reviewed By: alexfh

Subscribers: dkrupp, whisperity, rnkovacs, mgrang, cfe-commits

Patch by Tibor Brunner!

Tags: #clang

Differential Revision: https://reviews.llvm.org/D65065

llvm-svn: 369763
This commit is contained in:
Kristof Umann 2019-08-23 14:57:27 +00:00
parent 7d6aa7eb7f
commit dabfea85fc
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
View File

@ -742,8 +742,9 @@ struct LessClangTidyError {
const tooling::DiagnosticMessage &M1 = LHS.Message; const tooling::DiagnosticMessage &M1 = LHS.Message;
const tooling::DiagnosticMessage &M2 = RHS.Message; const tooling::DiagnosticMessage &M2 = RHS.Message;
return std::tie(M1.FilePath, M1.FileOffset, M1.Message) < return
std::tie(M2.FilePath, M2.FileOffset, M2.Message); std::tie(M1.FilePath, M1.FileOffset, LHS.DiagnosticName, M1.Message) <
std::tie(M2.FilePath, M2.FileOffset, RHS.DiagnosticName, M2.Message);
} }
}; };
struct EqualClangTidyError { struct EqualClangTidyError {

15
clang-tools-extra/test/clang-tidy/duplicate-reports.cpp Normal file
View File

@ -0,0 +1,15 @@
// RUN: %check_clang_tidy %s cert-err09-cpp,cert-err61-cpp %t
void alwaysThrows() {
int ex = 42;
// CHECK-MESSAGES: warning: throw expression should throw anonymous temporary values instead [cert-err09-cpp]
// CHECK-MESSAGES: warning: throw expression should throw anonymous temporary values instead [cert-err61-cpp]
throw ex;
}
void doTheJob() {
try {
alwaysThrows();
} catch (int&) {
}
}