forked from OSchip/llvm-project
Support: Improve performance of FileOutputBuffer on Windows
We extend an underlying file before mmap'ing it, but it's not needed on Windows. Extending file is slow on Windows, so we should avoid doing that. The difference gets larger as the size of an output file gets larger. It shove off 2 seconds out of 25 seconds when linking chrome.dll with LLD, for example. llvm-svn: 231452
This commit is contained in:
parent
55905145e7
commit
da9bc2e56d
|
@ -77,9 +77,16 @@ FileOutputBuffer::create(StringRef FilePath, size_t Size,
|
|||
if (EC)
|
||||
return EC;
|
||||
|
||||
#ifndef LLVM_ON_WIN32
|
||||
// On Windows, CreateFileMapping (the mmap function on Windows)
|
||||
// automatically extends the underlying file. We don't need to
|
||||
// extend the file beforehand. _chsize (ftruncate on Windows) is
|
||||
// pretty slow just like it writes specified amount of bytes,
|
||||
// so we should avoid calling that.
|
||||
EC = sys::fs::resize_file(FD, Size);
|
||||
if (EC)
|
||||
return EC;
|
||||
#endif
|
||||
|
||||
auto MappedFile = llvm::make_unique<mapped_file_region>(
|
||||
FD, mapped_file_region::readwrite, Size, 0, EC);
|
||||
|
|
Loading…
Reference in New Issue