From d774ae9ed11730123f526d2918734ad659643f69 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Thu, 26 Aug 2010 20:05:13 +0000 Subject: [PATCH] fix 2xi16 to pass as i32 instead of <2 x i16>. The former passes in memory (as required) the later now passes in an xmm register. This fixes gcc.dg/compat/vector_1 on x86-32. llvm-svn: 112211 --- clang/lib/CodeGen/TargetInfo.cpp | 19 +++++++++++++++++++ clang/test/CodeGen/x86_32-arguments.c | 8 +++++++- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/clang/lib/CodeGen/TargetInfo.cpp b/clang/lib/CodeGen/TargetInfo.cpp index 958f740bec38..05bea0cf8597 100644 --- a/clang/lib/CodeGen/TargetInfo.cpp +++ b/clang/lib/CodeGen/TargetInfo.cpp @@ -589,6 +589,25 @@ ABIArgInfo X86_32ABIInfo::classifyArgumentType(QualType Ty) const { return getIndirectResult(Ty); } + if (const VectorType *VT = Ty->getAs()) { + // On Darwin, some vectors are returned in registers. + if (IsDarwinVectorABI) { + uint64_t Size = getContext().getTypeSize(Ty); + + // Always return in register if it fits in a general purpose + // register, or if it is 64 bits and has a single element. + if ((Size == 8 || Size == 16 || Size == 32) || + (Size == 64 && VT->getNumElements() == 1)) + return ABIArgInfo::getDirect(llvm::IntegerType::get(getVMContext(), + Size)); + + return ABIArgInfo::getIndirect(0); + } + + return ABIArgInfo::getDirect(); + } + + if (const EnumType *EnumTy = Ty->getAs()) Ty = EnumTy->getDecl()->getIntegerType(); diff --git a/clang/test/CodeGen/x86_32-arguments.c b/clang/test/CodeGen/x86_32-arguments.c index 01c3e236f3bd..4f2a6a3a38e4 100644 --- a/clang/test/CodeGen/x86_32-arguments.c +++ b/clang/test/CodeGen/x86_32-arguments.c @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -fblocks -triple i386-apple-darwin9 -emit-llvm -o %t %s +// RUN: %clang_cc1 -w -fblocks -triple i386-apple-darwin9 -emit-llvm -o %t %s // RUN: FileCheck < %t %s // CHECK: define signext i8 @f0() @@ -214,3 +214,9 @@ struct __attribute__((aligned(32))) s53 { int y; }; void f53(struct s53 x) {} + +typedef unsigned short v2i16 __attribute__((__vector_size__(4))); + +// CHECK: define i32 @f54(i32 %arg.coerce) +v2i16 f54(v2i16 arg) { return arg+arg; } +