maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Static analyzer noticed that a null get_pending_items_caller could 

be used.  Guard against that.

llvm-svn: 251584
This commit is contained in:
Jason Molenda 2015-10-29 00:08:03 +00:00
parent 8fe108766f
commit d76b2a42f2
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetPendingItemsHandler.cpp
View File

@ -178,7 +178,6 @@ AppleGetPendingItemsHandler::SetupGetPendingItemsFunction (Thread &thread, Value
{ {
if (log) if (log)
log->Printf("No pending-items introspection code found."); log->Printf("No pending-items introspection code found.");
errors.Printf ("No pending-items introspection code found.");
return LLDB_INVALID_ADDRESS; return LLDB_INVALID_ADDRESS;
} }
@ -202,6 +201,13 @@ AppleGetPendingItemsHandler::SetupGetPendingItemsFunction (Thread &thread, Value
errors.Clear(); errors.Clear();
if (get_pending_items_caller == nullptr)
{
if (log)
log->Printf ("Failed to get get_pending_items_caller.");
return LLDB_INVALID_ADDRESS;
}
// Now write down the argument values for this particular call. This looks like it might be a race condition // Now write down the argument values for this particular call. This looks like it might be a race condition
// if other threads were calling into here, but actually it isn't because we allocate a new args structure for // if other threads were calling into here, but actually it isn't because we allocate a new args structure for
// this call by passing args_addr = LLDB_INVALID_ADDRESS... // this call by passing args_addr = LLDB_INVALID_ADDRESS...