maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ASan] Use stack safety analysis to optimize allocas instrumentation. 

Added alloca optimization which was missed during the implemenation of D112098.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D130503
This commit is contained in:
Kirill Stoimenov 2022-07-26 18:29:31 -07:00 committed by Vitaly Buka
parent 704a6ea507
commit d6e1e0a019
2 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
View File

@ -1232,7 +1232,9 @@ bool AddressSanitizer::isInterestingAlloca(const AllocaInst &AI) {
// dynamic alloca instrumentation for them as well. // dynamic alloca instrumentation for them as well.
!AI.isUsedWithInAlloca() && !AI.isUsedWithInAlloca() &&
// swifterror allocas are register promoted by ISel // swifterror allocas are register promoted by ISel
!AI.isSwiftError()); !AI.isSwiftError() &&
// safe allocas are not interesting
!(SSGI && SSGI->isSafe(AI)));
ProcessedAllocas[&AI] = IsInteresting; ProcessedAllocas[&AI] = IsInteresting;
return IsInteresting; return IsInteresting;

21
llvm/test/Instrumentation/AddressSanitizer/asan-stack-safety.ll
View File

@ -6,7 +6,7 @@
; CHECK-LABEL: define i32 @load ; CHECK-LABEL: define i32 @load
define i32 @load() sanitize_address { define i32 @load() sanitize_address {
%buf = alloca [10 x i8], align 1 %buf = alloca [10 x i8], align 1
; CHECK: call i64 @__asan_stack_malloc ; NOSAFETY: call i64 @__asan_stack_malloc
%arrayidx = getelementptr inbounds [10 x i8], [10 x i8]* %buf, i64 0, i64 0 %arrayidx = getelementptr inbounds [10 x i8], [10 x i8]* %buf, i64 0, i64 0
%1 = load i8, i8* %arrayidx, align 1 %1 = load i8, i8* %arrayidx, align 1
; NOSAFETY: call void @__asan_load1 ; NOSAFETY: call void @__asan_load1
@ -16,17 +16,30 @@ define i32 @load() sanitize_address {
; CHECK-LABEL: define i32 @store ; CHECK-LABEL: define i32 @store
define i32 @store() sanitize_address { define i32 @store() sanitize_address {
%buf = alloca [10 x i8], align 1 %buf = alloca [10 x i8], align 1
; CHECK: call i64 @__asan_stack_malloc ; NOSAFETY: call i64 @__asan_stack_malloc
%arrayidx = getelementptr inbounds [10 x i8], [10 x i8]* %buf, i64 0, i64 0 %arrayidx = getelementptr inbounds [10 x i8], [10 x i8]* %buf, i64 0, i64 0
store i8 0, i8* %arrayidx store i8 0, i8* %arrayidx
; NOSAFETY: call void @__asan_store1 ; NOSAFETY: call void @__asan_store1
ret i32 0 ret i32 0
} }
; CHECK-LABEL: define i32 @unsafe_alloca
define i32 @unsafe_alloca(i32 %i) sanitize_address {
%buf.sroa.0 = alloca [10 x i8], align 4
; CHECK: call i64 @__asan_stack_malloc
%ptr = getelementptr [10 x i8], [10 x i8]* %buf.sroa.0, i32 %i, i32 0
store volatile i8 0, i8* %ptr, align 4
; CHECK: call void @__asan_store1
%ptr2 = getelementptr [10 x i8], [10 x i8]* %buf.sroa.0, i32 0, i32 0
store volatile i8 0, i8* %ptr2, align 4
; NOSAFETY: call void @__asan_store1
ret i32 0
}
; CHECK-LABEL: define void @atomicrmw ; CHECK-LABEL: define void @atomicrmw
define void @atomicrmw() sanitize_address { define void @atomicrmw() sanitize_address {
%buf = alloca [10 x i8], align 1 %buf = alloca [10 x i8], align 1
; CHECK: call i64 @__asan_stack_malloc ; NOSAFETY: call i64 @__asan_stack_malloc
%arrayidx = getelementptr inbounds [10 x i8], [10 x i8]* %buf, i64 0, i64 0 %arrayidx = getelementptr inbounds [10 x i8], [10 x i8]* %buf, i64 0, i64 0
%1 = atomicrmw add i8* %arrayidx, i8 1 seq_cst %1 = atomicrmw add i8* %arrayidx, i8 1 seq_cst
; NOSAFETY: call void @__asan_store1 ; NOSAFETY: call void @__asan_store1
@ -36,7 +49,7 @@ define void @atomicrmw() sanitize_address {
; CHECK-LABEL: define void @cmpxchg ; CHECK-LABEL: define void @cmpxchg
define void @cmpxchg(i8 %compare_to, i8 %new_value) sanitize_address { define void @cmpxchg(i8 %compare_to, i8 %new_value) sanitize_address {
%buf = alloca [10 x i8], align 1 %buf = alloca [10 x i8], align 1
; CHECK: call i64 @__asan_stack_malloc ; NOSAFETY: call i64 @__asan_stack_malloc
%arrayidx = getelementptr inbounds [10 x i8], [10 x i8]* %buf, i64 0, i64 0 %arrayidx = getelementptr inbounds [10 x i8], [10 x i8]* %buf, i64 0, i64 0
%1 = cmpxchg i8* %arrayidx, i8 %compare_to, i8 %new_value seq_cst seq_cst %1 = cmpxchg i8* %arrayidx, i8 %compare_to, i8 %new_value seq_cst seq_cst
; NOSAFETY: call void @__asan_store1 ; NOSAFETY: call void @__asan_store1