Revert r359717, "Make check-clang depend on the clang-check binary always"

The Tooling tests do have a lit.local.cfg with

    if not config.root.clang_staticanalyzer:
        config.unsupported = True

so what's wrong isn't the missing dep, but that lit prints a warning for
the binary missing. This will need a different kind of fix.

llvm-svn: 359739

clang/test/CMakeLists.txt

@@ -49,7 +49,6 @@ list(APPEND CLANG_TEST_DEPS
   c-index-test
   clang
   clang-resource-headers
-  clang-check
   clang-format
   clang-tblgen
   clang-offload-bundler
@@ -63,6 +62,7 @@ list(APPEND CLANG_TEST_DEPS
   
 if(CLANG_ENABLE_STATIC_ANALYZER)
   list(APPEND CLANG_TEST_DEPS
+    clang-check
     clang-extdef-mapping
     )
 endif()

llvm/utils/gn/secondary/clang/test/BUILD.gn

@@ -108,7 +108,6 @@ group("test") {
     ":lit_unit_site_cfg",
     "//clang/lib/Headers",
     "//clang/tools/c-index-test",
-    "//clang/tools/clang-check",
     "//clang/tools/clang-diff",
     "//clang/tools/clang-format",
     "//clang/tools/clang-import-test",
@@ -148,6 +147,7 @@ group("test") {
   }
   if (clang_enable_static_analyzer) {
     deps += [
+      "//clang/tools/clang-check",
       "//clang/tools/clang-extdef-mapping",
     ]
   }