maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

When promoting the result of fp_to_uint/fp_to_sint, 

inform the optimizers that the result must be zero/
sign extended from the smaller type.  For example,
if a fp to unsigned i16 is promoted to fp to i32,
then we are allowed to assume that the extra 16 bits
are zero (because the result of fp to i16 is undefined
if the result does not fit in an i16).  This is
quite aggressive, but should help the optimizers
produce better code.  This requires correcting a
test which thought that fp_to_uint is some kind
of truncation, which it is not: in the testcase
(which does fp to i1), either the fp value converts
to 0 or 1 or the result is undefined, which is
quite different to truncation.

llvm-svn: 58991
This commit is contained in:
Duncan Sands 2008-11-10 17:28:30 +00:00
parent d36ed56c52
commit d5b53e1c6c
2 changed files with 15 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
View File

@ -267,7 +267,7 @@ SDValue DAGTypeLegalizer::PromoteIntRes_Constant(SDNode *N) {
// matter in theory which one we pick, but this tends to give better code? // matter in theory which one we pick, but this tends to give better code?
unsigned Opc = VT.isByteSized() ? ISD::SIGN_EXTEND : ISD::ZERO_EXTEND; unsigned Opc = VT.isByteSized() ? ISD::SIGN_EXTEND : ISD::ZERO_EXTEND;
SDValue Result = DAG.getNode(Opc, TLI.getTypeToTransformTo(VT), SDValue Result = DAG.getNode(Opc, TLI.getTypeToTransformTo(VT),
SDValue(N, 0)); SDValue(N, 0));
assert(isa<ConstantSDNode>(Result) && "Didn't constant fold ext?"); assert(isa<ConstantSDNode>(Result) && "Didn't constant fold ext?");
return Result; return Result;
} }
@ -350,22 +350,27 @@ SDValue DAGTypeLegalizer::PromoteIntRes_EXTRACT_VECTOR_ELT(SDNode *N) {
} }
SDValue DAGTypeLegalizer::PromoteIntRes_FP_TO_XINT(SDNode *N) { SDValue DAGTypeLegalizer::PromoteIntRes_FP_TO_XINT(SDNode *N) {
unsigned NewOpc = N->getOpcode();
MVT NVT = TLI.getTypeToTransformTo(N->getValueType(0)); MVT NVT = TLI.getTypeToTransformTo(N->getValueType(0));
unsigned NewOpc = N->getOpcode();
// If we're promoting a UINT to a larger size, check to see if the new node // If we're promoting a UINT to a larger size, check to see if the new node
// will be legal. If it isn't, check to see if FP_TO_SINT is legal, since // will be legal. If it isn't, check to see if FP_TO_SINT is legal, since
// we can use that instead. This allows us to generate better code for // we can use that instead. This allows us to generate better code for
// FP_TO_UINT for small destination sizes on targets where FP_TO_UINT is not // FP_TO_UINT for small destination sizes on targets where FP_TO_UINT is not
// legal, such as PowerPC. // legal, such as PowerPC.
if (N->getOpcode() == ISD::FP_TO_UINT) { if (N->getOpcode() == ISD::FP_TO_UINT &&
if (!TLI.isOperationLegal(ISD::FP_TO_UINT, NVT) && !TLI.isOperationLegal(ISD::FP_TO_UINT, NVT) &&
(TLI.isOperationLegal(ISD::FP_TO_SINT, NVT) || TLI.isOperationLegal(ISD::FP_TO_SINT, NVT))
TLI.getOperationAction(ISD::FP_TO_SINT, NVT)==TargetLowering::Custom)) NewOpc = ISD::FP_TO_SINT;
NewOpc = ISD::FP_TO_SINT;
}
return DAG.getNode(NewOpc, NVT, N->getOperand(0)); SDValue Res = DAG.getNode(NewOpc, NVT, N->getOperand(0));
// Assert that the converted value fits in the original type. If it doesn't
// (eg: because the value being converted is too big), then the result of the
// original operation was undefined anyway, so the assert is still correct.
return DAG.getNode(N->getOpcode() == ISD::FP_TO_UINT ?
ISD::AssertZext : ISD::AssertSext,
NVT, Res, DAG.getValueType(N->getValueType(0)));
} }
SDValue DAGTypeLegalizer::PromoteIntRes_INT_EXTEND(SDNode *N) { SDValue DAGTypeLegalizer::PromoteIntRes_INT_EXTEND(SDNode *N) {

11
llvm/test/CodeGen/X86/trunc-to-bool.ll
View File

@ -2,7 +2,7 @@
; sure only the LSBit survives. Test that this is the case both for a returned ; sure only the LSBit survives. Test that this is the case both for a returned
; value and as the operand of a branch. ; value and as the operand of a branch.
; RUN: llvm-as < %s | llc -march=x86 | grep {\\(and\\)\\|\\(test.*\\\$1\\)} | \ ; RUN: llvm-as < %s | llc -march=x86 | grep {\\(and\\)\\|\\(test.*\\\$1\\)} | \
; RUN: count 6 ; RUN: count 5
define i1 @test1(i32 %X) zeroext { define i1 @test1(i32 %X) zeroext {
%Y = trunc i32 %X to i1 %Y = trunc i32 %X to i1
@ -40,15 +40,6 @@ cond_false:
ret i32 42 ret i32 42
} }
define i32 @test5(float %f) {
%tmp = fptoui float %f to i1
br i1 %tmp, label %cond_true, label %cond_false
cond_true:
ret i32 21
cond_false:
ret i32 42
}
define i32 @test6(double %d) { define i32 @test6(double %d) {
%tmp = fptosi double %d to i1 %tmp = fptosi double %d to i1
br i1 %tmp, label %cond_true, label %cond_false br i1 %tmp, label %cond_true, label %cond_false