From d5397f4efe126c5fa1cebf9634d8c1e12d21ec56 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Wed, 22 May 2019 12:22:51 -0700 Subject: [PATCH] Return nullptr on Region::getContainingOperation()/getContainingFunction() instead of asserting This avoids crashing when trying to dump an operation nested in a region that isn't yet attached to an operation, which is quite useful when debugging. This alone won't be enough to print an unlink Operation, it'll display `<>`. -- PiperOrigin-RevId: 249496388 --- mlir/lib/IR/Block.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/mlir/lib/IR/Block.cpp b/mlir/lib/IR/Block.cpp index a440ca9ee719..2ed8fd0e4fdf 100644 --- a/mlir/lib/IR/Block.cpp +++ b/mlir/lib/IR/Block.cpp @@ -289,12 +289,10 @@ Region *Region::getContainingRegion() { } Operation *Region::getContainingOp() { - assert(!container.isNull() && "no container"); return container.dyn_cast(); } Function *Region::getContainingFunction() { - assert(!container.isNull() && "no container"); return container.dyn_cast(); }