maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libc++abi] Properly fix XFAILs for exception alignment 

Since <unwind.h> is in the SDK, not in /usr/include, the XFAILs must
be predicated on the compiler version (ideally even on the SDK version)
instead of the target system version.
This commit is contained in:
Louis Dionne 2020-06-05 13:06:37 -04:00
parent 56ce65e2b6
commit d520dfec3b
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
libcxxabi/test/test_exception_address_alignment.pass.cpp
View File

@ -9,14 +9,13 @@
// UNSUPPORTED: no-exceptions
// UNSUPPORTED: c++03
// The system unwind.h on older OSX versions provided an incorrectly aligned
// _Unwind_Exception type. That causes these tests to fail on those platforms.
// XFAIL: macosx10.14 && libcxxabi-has-system-unwinder
// XFAIL: macosx10.13 && libcxxabi-has-system-unwinder
// XFAIL: macosx10.12 && libcxxabi-has-system-unwinder
// XFAIL: macosx10.11 && libcxxabi-has-system-unwinder
// XFAIL: macosx10.10 && libcxxabi-has-system-unwinder
// XFAIL: macosx10.9 && libcxxabi-has-system-unwinder
// The <unwind.h> header provided in the SDK of older Xcodes used to provide
// an incorrectly aligned _Unwind_Exception type. That causes these tests to
// fail with those SDKs. Note that we use the AppleClang version as a cheap
// proxy for the SDK version.
// XFAIL: apple-clang-11 && libcxxabi-has-system-unwinder
// XFAIL: apple-clang-10 && libcxxabi-has-system-unwinder
// XFAIL: apple-clang-9 && libcxxabi-has-system-unwinder
// Test that the address of the exception object is properly aligned as required
// by the relevant ABI