From d4db94846ad6c3db02d82dca0aa7af2df8296f20 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Fri, 8 Jan 2016 17:05:12 +0000 Subject: [PATCH] How to close a review manually. llvm-svn: 257180 --- llvm/docs/Phabricator.rst | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/llvm/docs/Phabricator.rst b/llvm/docs/Phabricator.rst index 73704d9b17d7..af1e4429fda9 100644 --- a/llvm/docs/Phabricator.rst +++ b/llvm/docs/Phabricator.rst @@ -136,7 +136,7 @@ reviewers, the ``Differential Revision``, etc from the review and commit it to t arc commit --revision D -When committing an LLVM change that has been reviewed using +When committing a change that has been reviewed using Phabricator, the convention is for the commit message to end with the line: @@ -153,6 +153,12 @@ This allows people reading the version history to see the review for context. This also allows Phabricator to detect the commit, close the review, and add a link from the review to the commit. +If you use ``git`` or ``svn`` to commit the change and forget to add the line +to your commit message, you should close the review manually. In the web UI, +under "Leap Into Action" put the SVN revision number in the Comment, set the +Action to "Close Revision" and click Submit. Note the review must have been +Accepted first. + Abandoning a change -------------------