maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

How to close a review manually. 

llvm-svn: 257180
This commit is contained in:
Paul Robinson 2016-01-08 17:05:12 +00:00
parent 4b4f4b90ed
commit d4db94846a
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
llvm/docs/Phabricator.rst
View File

@ -136,7 +136,7 @@ reviewers, the ``Differential Revision``, etc from the review and commit it to t
arc commit --revision D<Revision>
When committing an LLVM change that has been reviewed using
When committing a change that has been reviewed using
Phabricator, the convention is for the commit message to end with the
line:
@ -153,6 +153,12 @@ This allows people reading the version history to see the review for
context. This also allows Phabricator to detect the commit, close the
review, and add a link from the review to the commit.
If you use ``git`` or ``svn`` to commit the change and forget to add the line
to your commit message, you should close the review manually. In the web UI,
under "Leap Into Action" put the SVN revision number in the Comment, set the
Action to "Close Revision" and click Submit. Note the review must have been
Accepted first.
Abandoning a change
-------------------