maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix up a couple of review comments: 

Use an if statement instead of a pair of ternary operators checking
the same condition.
Use a cheap method call rather than returning the local symbol.

llvm-svn: 198351
This commit is contained in:
Eric Christopher 2014-01-02 21:03:28 +00:00
parent 8bdb6e1d49
commit d4368fde45
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
View File

@ -822,14 +822,14 @@ DwarfCompileUnit *DwarfDebug::constructDwarfCompileUnit(DICompileUnit DIUnit) {
if (!FirstCU)
FirstCU = NewCU;
NewCU->initSection(
useSplitDwarf() ? Asm->getObjFileLowering().getDwarfInfoDWOSection()
: Asm->getObjFileLowering().getDwarfInfoSection(),
useSplitDwarf() ? DwarfInfoDWOSectionSym : DwarfInfoSectionSym);
// If we're splitting the dwarf then construct the skeleton CU now.
if (useSplitDwarf())
if (useSplitDwarf()) {
NewCU->initSection(Asm->getObjFileLowering().getDwarfInfoDWOSection(),
DwarfInfoDWOSectionSym);
// If we're splitting the dwarf then construct the skeleton CU now.
NewCU->setSkeleton(constructSkeletonCU(NewCU));
} else
NewCU->initSection(Asm->getObjFileLowering().getDwarfInfoSection(),
DwarfInfoSectionSym);
CUMap.insert(std::make_pair(DIUnit, NewCU));
CUDieMap.insert(std::make_pair(Die, NewCU));

4
llvm/lib/CodeGen/AsmPrinter/DwarfUnit.h
View File

@ -185,7 +185,7 @@ public:
MCSymbol *getLocalSectionSym() const {
if (Skeleton)
return Skeleton->getSectionSym();
return SectionSym;
return getSectionSym();
}
MCSymbol *getSectionSym() const {
@ -198,7 +198,7 @@ public:
MCSymbol *getLocalLabelBegin() const {
if (Skeleton)
return Skeleton->getLabelBegin();
return LabelBegin;
return getLabelBegin();
}
MCSymbol *getLabelBegin() const {