maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Remove case in rewritergen unmatched opdefgen side 

The rewriter generates a call to build that is not handled by opdef generator
and so will fail to compile. Also if this is a root node being replaced
(depth 0) then using the more generic build method in the rewrite suffices.
This commit is contained in:
Jacques Pienaar 2020-04-06 15:55:25 -07:00
parent 5f185a8999
commit d3a31c4db4
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mlir/tools/mlir-tblgen/RewriterGen.cpp
View File

@ -819,17 +819,9 @@ std::string PatternEmitter::handleOpCreation(DagNode tree, int resultIndex,
return resultValue;
}
// TODO: Remove once broadcastable has been updated. This query here is not
// really about broadcastable or not, it is about which build method to invoke
// and that requires knowledge of whether ODS generated a builder that need
// not take return types. That knowledge should be captured in one place
// rather than duplicated.
bool isResultsBroadcastableShape =
resultOp.getTrait("OpTrait::ResultsBroadcastableShape");
bool usePartialResults = valuePackName != resultValue;
if (isResultsBroadcastableShape || usePartialResults || depth > 0 ||
resultIndex < 0) {
if (usePartialResults || depth > 0 || resultIndex < 0) {
// For these cases (broadcastable ops, op results used both as auxiliary
// values and replacement values, ops in nested patterns, auxiliary ops), we
// still need to supply the result types when building the op. But because