From d3a20c9e1eb20f536f7613e6f31c552655efdb7b Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Tue, 11 Mar 2008 16:41:42 +0000 Subject: [PATCH] Give PassManager and FunctionPassManager a common base class, with add(Pass *) as a pure virtual member function. This will allow all the various addPassesTo* functions in LLVM to avoid hard-coding what type of PassManager is used. llvm-svn: 48226 --- llvm/include/llvm/PassManager.h | 18 ++++++++++++++++-- llvm/lib/VMCore/PassManager.cpp | 2 +- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/llvm/include/llvm/PassManager.h b/llvm/include/llvm/PassManager.h index 6d462026e3a2..294b8453015a 100644 --- a/llvm/include/llvm/PassManager.h +++ b/llvm/include/llvm/PassManager.h @@ -29,8 +29,22 @@ class ModuleProvider; class PassManagerImpl; class FunctionPassManagerImpl; +/// PassManagerBase - An abstract interface to allow code to add passes to +/// a pass manager without having to hard-code what kind of pass manager +/// it is. +class PassManagerBase { +public: + virtual ~PassManagerBase(); + + /// add - Add a pass to the queue of passes to run. This passes ownership of + /// the Pass to the PassManager. When the PassManager is destroyed, the pass + /// will be destroyed as well, so there is no need to delete the pass. This + /// implies that all passes MUST be allocated with 'new'. + virtual void add(Pass *P) = 0; +}; + /// PassManager manages ModulePassManagers -class PassManager { +class PassManager : public PassManagerBase { public: PassManager(); @@ -54,7 +68,7 @@ private: }; /// FunctionPassManager manages FunctionPasses and BasicBlockPassManagers. -class FunctionPassManager { +class FunctionPassManager : public PassManagerBase { public: /// FunctionPassManager ctor - This initializes the pass manager. It needs, /// but does not take ownership of, the specified module provider. diff --git a/llvm/lib/VMCore/PassManager.cpp b/llvm/lib/VMCore/PassManager.cpp index 16966452e1b2..bef1171bd0e4 100644 --- a/llvm/lib/VMCore/PassManager.cpp +++ b/llvm/lib/VMCore/PassManager.cpp @@ -1531,4 +1531,4 @@ void BasicBlockPass::assignPassManager(PMStack &PMS, BBP->add(this); } - +PassManagerBase::~PassManagerBase() {}