forked from OSchip/llvm-project
[CUDA] Don't assume that destructors can't be overloaded.
Summary: You can overload a destructor in CUDA, and SemaOverload needs to be tweaked not to crash when it sees an explicit call to an overloaded destructor. Reviewers: rsmith Subscribers: cfe-commits, tra Differential Revision: http://reviews.llvm.org/D21912 llvm-svn: 275231
This commit is contained in:
parent
51078b81ca
commit
d35f706cc2
|
@ -12407,8 +12407,7 @@ Sema::BuildCallToMemberFunction(Scope *S, Expr *MemExprE,
|
||||||
if (CXXDestructorDecl *DD =
|
if (CXXDestructorDecl *DD =
|
||||||
dyn_cast<CXXDestructorDecl>(TheCall->getMethodDecl())) {
|
dyn_cast<CXXDestructorDecl>(TheCall->getMethodDecl())) {
|
||||||
// a->A::f() doesn't go through the vtable, except in AppleKext mode.
|
// a->A::f() doesn't go through the vtable, except in AppleKext mode.
|
||||||
bool CallCanBeVirtual = !cast<MemberExpr>(NakedMemExpr)->hasQualifier() ||
|
bool CallCanBeVirtual = !MemExpr->hasQualifier() || getLangOpts().AppleKext;
|
||||||
getLangOpts().AppleKext;
|
|
||||||
CheckVirtualDtorCall(DD, MemExpr->getLocStart(), /*IsDelete=*/false,
|
CheckVirtualDtorCall(DD, MemExpr->getLocStart(), /*IsDelete=*/false,
|
||||||
CallCanBeVirtual, /*WarnOnNonAbstractTypes=*/true,
|
CallCanBeVirtual, /*WarnOnNonAbstractTypes=*/true,
|
||||||
MemExpr->getMemberLoc());
|
MemExpr->getMemberLoc());
|
||||||
|
|
|
@ -0,0 +1,17 @@
|
||||||
|
// expected-no-diagnostics
|
||||||
|
|
||||||
|
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -verify %s
|
||||||
|
// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -fsyntax-only -fcuda-is-device -verify %s
|
||||||
|
|
||||||
|
#include "Inputs/cuda.h"
|
||||||
|
|
||||||
|
struct S {
|
||||||
|
__host__ ~S() {}
|
||||||
|
__device__ ~S() {}
|
||||||
|
};
|
||||||
|
|
||||||
|
__host__ __device__ void test() {
|
||||||
|
S s;
|
||||||
|
// This should not crash clang.
|
||||||
|
s.~S();
|
||||||
|
}
|
Loading…
Reference in New Issue