maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Add mention to avoid cl::opt for MLIR passes in the developer guide 

PiperOrigin-RevId: 281338448
This commit is contained in:
Mehdi Amini 2019-11-19 11:25:37 -08:00 committed by A. Unique TensorFlower
parent dd5a7cb488
commit d324c613ea
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mlir/g3doc/DeveloperGuide.md
View File

@ -38,6 +38,12 @@ with the pass name. For example, the affine dialect provides a loop tiling pass
that is registered on the command line as `-affine-tile`, and with a tile size that is registered on the command line as `-affine-tile`, and with a tile size
option that can be set with `-affine-tile-size`. option that can be set with `-affine-tile-size`.
We also avoid `cl::opt` to provide pass options in favor of the
[pass options](WritingAPass.md#instance-specific-pass-options) mechanism. This
allows for these options to be serialized in a pass pipeline description, as
well as passing different options to multiple instances of a pass in the same
pipeline.
## Testing guidelines ## Testing guidelines
See here for the [testing guide](TestingGuide.md). See here for the [testing guide](TestingGuide.md).