[analyzer] Malloc checker: make a bit safer.

llvm-svn: 150556
This commit is contained in:
Anna Zaks 2012-02-15 02:12:00 +00:00
parent 19582e85bd
commit d1ff1cbe23
1 changed files with 6 additions and 2 deletions

View File

@ -265,11 +265,14 @@ void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
}
bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
initIdentifierInfo(C);
if (!FD)
return false;
IdentifierInfo *FunI = FD->getIdentifier();
if (!FunI)
return false;
initIdentifierInfo(C);
// TODO: Add more here : ex: reallocf!
if (FunI == II_malloc || FunI == II_free || FunI == II_realloc ||
FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc)
@ -1006,7 +1009,8 @@ MallocChecker::checkRegionChanges(ProgramStateRef State,
return State;
llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
const FunctionDecl *FD = (Call ? dyn_cast<FunctionDecl>(Call->getDecl()) : 0);
const FunctionDecl *FD = (Call ?
dyn_cast_or_null<FunctionDecl>(Call->getDecl()) :0);
// If it's a call which might free or reallocate memory, we assume that all
// regions (explicit and implicit) escaped. Otherwise, whitelist explicit