maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[RISCV] Replace llvm_unreachable with report_fatal_error. 

Parsing errors aren't handled earlier in all cases. A simple
example is llc -mtriple=riscv64 -mattr=+zve32f. If F or Finx is
not also specified, this will hit a parse error.

Use a fatal_error so that the error is conveyed to the user.
This commit is contained in:
Craig Topper 2022-02-14 12:06:38 -08:00
parent d1e3235f60
commit d132b47bb9
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.cpp
View File

@ -48,9 +48,7 @@ void RISCVTargetStreamer::emitTargetAttributes(const MCSubtargetInfo &STI) {
auto ParseResult = RISCVFeatures::parseFeatureBits( auto ParseResult = RISCVFeatures::parseFeatureBits(
STI.hasFeature(RISCV::Feature64Bit), STI.getFeatureBits()); STI.hasFeature(RISCV::Feature64Bit), STI.getFeatureBits());
if (!ParseResult) { if (!ParseResult) {
/* Assume any error about features should handled earlier. */ report_fatal_error(ParseResult.takeError());
consumeError(ParseResult.takeError());
llvm_unreachable("Parsing feature error when emitTargetAttributes?");
} else { } else {
auto &ISAInfo = *ParseResult; auto &ISAInfo = *ParseResult;
emitTextAttribute(RISCVAttrs::ARCH, ISAInfo->toString()); emitTextAttribute(RISCVAttrs::ARCH, ISAInfo->toString());