[bitcode reader] Fix an assert on invalid type tables

Bug found with afl-fuzz llvm-svn: 227566
2015-01-30 10:57:58 +00:00 · 2015-01-30 10:57:58 +00:00 · d0858e1037
parent cc6e894587
commit d0858e1037
2 changed files with 3 additions and 1 deletions
--- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
+++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
@ -1095,8 +1095,10 @@ std::error_code BitcodeReader::ParseTypeTableBody() {

    if (NumRecords >= TypeList.size())
      return Error("Invalid TYPE table");
+    if (TypeList[NumRecords])
+      return Error(
+          "Invalid TYPE table: Only named structs can be forward referenced");
    assert(ResultTy && "Didn't read a type?");
-    assert(!TypeList[NumRecords] && "Already read type?");
    TypeList[NumRecords++] = ResultTy;
  }
 }
--- a/llvm/test/Bitcode/Inputs/invalid-type-table-forward-ref.bc
+++ b/llvm/test/Bitcode/Inputs/invalid-type-table-forward-ref.bc