maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ValueTracking] Avoid blind cast from Operator to Instruction 

Summary:
Avoid blind cast from Operator to ExtractElementInst in
computeKnownBitsFromOperator. This resulted in some crashes
in downstream fuzzy testing. Instead we use getOperand directly
on the Operator when accessing the vector/index operands.

Haven't seen any problems with InsertElement and ShuffleVector,
but I believe those could be used in constant expressions as well.
So the same kind of fix as for ExtractElement was also applied for
InsertElement.

When it comes to ShuffleVector we now simply bail out if a dynamic
cast of the Operator to ShuffleVectorInst fails. I've got no
reproducer indicating problems for ShuffleVector, and a fix would be
slightly more complicated as getShuffleDemandedElts is involved.

Reviewers: RKSimon, nikic, spatel, efriedma

Reviewed By: RKSimon

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D76564
This commit is contained in:
Bjorn Pettersson 2020-03-22 12:16:42 +01:00
parent a63eaa5449
commit d077d678d3
2 changed files with 26 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
llvm/lib/Analysis/ValueTracking.cpp
View File

@ -1737,7 +1737,12 @@ static void computeKnownBitsFromOperator(const Operator *I,
} }
break; break;
case Instruction::ShuffleVector: { case Instruction::ShuffleVector: {
auto *Shuf = cast<ShuffleVectorInst>(I); auto *Shuf = dyn_cast<ShuffleVectorInst>(I);
// FIXME: Do we need to handle ConstantExpr involving shufflevectors?
if (!Shuf) {
Known.resetAll();
return;
}
// For undef elements, we don't know anything about the common state of // For undef elements, we don't know anything about the common state of
// the shuffle result. // the shuffle result.
APInt DemandedLHS, DemandedRHS; APInt DemandedLHS, DemandedRHS;
@ -1763,10 +1768,9 @@ static void computeKnownBitsFromOperator(const Operator *I,
break; break;
} }
case Instruction::InsertElement: { case Instruction::InsertElement: {
auto *IEI = cast<InsertElementInst>(I); const Value *Vec = I->getOperand(0);
Value *Vec = IEI->getOperand(0); const Value *Elt = I->getOperand(1);
Value *Elt = IEI->getOperand(1); auto *CIdx = dyn_cast<ConstantInt>(I->getOperand(2));
auto *CIdx = dyn_cast<ConstantInt>(IEI->getOperand(2));
// Early out if the index is non-constant or out-of-range. // Early out if the index is non-constant or out-of-range.
unsigned NumElts = DemandedElts.getBitWidth(); unsigned NumElts = DemandedElts.getBitWidth();
if (!CIdx || CIdx->getValue().uge(NumElts)) { if (!CIdx || CIdx->getValue().uge(NumElts)) {
@ -1796,9 +1800,8 @@ static void computeKnownBitsFromOperator(const Operator *I,
case Instruction::ExtractElement: { case Instruction::ExtractElement: {
// Look through extract element. If the index is non-constant or // Look through extract element. If the index is non-constant or
// out-of-range demand all elements, otherwise just the extracted element. // out-of-range demand all elements, otherwise just the extracted element.
auto* EEI = cast<ExtractElementInst>(I); const Value *Vec = I->getOperand(0);
const Value* Vec = EEI->getVectorOperand(); const Value *Idx = I->getOperand(1);
const Value* Idx = EEI->getIndexOperand();
auto *CIdx = dyn_cast<ConstantInt>(Idx); auto *CIdx = dyn_cast<ConstantInt>(Idx);
unsigned NumElts = Vec->getType()->getVectorNumElements(); unsigned NumElts = Vec->getType()->getVectorNumElements();
APInt DemandedVecElts = APInt::getAllOnesValue(NumElts); APInt DemandedVecElts = APInt::getAllOnesValue(NumElts);

15
llvm/test/Analysis/ValueTracking/known-bits-from-operator-constexpr.ll Normal file
View File

@ -0,0 +1,15 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -instsimplify -S | FileCheck %s
; Reproducer for a crash in computeKnownBitsFromOperator due to blindly
; casting from llvm::Operator to ExtractElementInst. That does not work
; if the Operator is a ConstantExpr.
@g = global [21 x i32] zeroinitializer
define i32 @test1(i32 %a) {
; CHECK-LABEL: @test1(
; CHECK-NEXT: [[T:%.*]] = sub i32 [[A:%.*]], extractelement (<4 x i32> ptrtoint (<4 x i32*> getelementptr inbounds ([21 x i32], [21 x i32]* @g, <4 x i32> zeroinitializer, <4 x i32> <i32 1, i32 2, i32 3, i32 17>) to <4 x i32>), i32 3)
; CHECK-NEXT: ret i32 [[T]]
;
%t = sub i32 %a, extractelement (<4 x i32> ptrtoint (<4 x i32 *> getelementptr inbounds ([21 x i32], [21 x i32] * @g, <4 x i32> zeroinitializer, <4 x i32> <i32 1, i32 2, i32 3, i32 17>) to <4 x i32>), i32 3)
ret i32 %t
}