Don't ignore the return value of AsmPrinter::doInitialization and

AsmPrinter::doFinalization.

llvm-svn: 40487

llvm/lib/Target/ARM/ARMAsmPrinter.cpp

@@ -789,13 +789,13 @@ bool ARMAsmPrinter::doInitialization(Module &M) {
   // Emit initial debug information.
   DW.BeginModule(&M);
   
-  AsmPrinter::doInitialization(M);
+  bool Result = AsmPrinter::doInitialization(M);
 
   // Darwin wants symbols to be quoted if they have complex names.
   if (Subtarget->isTargetDarwin())
     Mang->setUseQuotes(true);
 
-  return false;
+  return Result;
 }
 
 bool ARMAsmPrinter::doFinalization(Module &M) {
@@ -1024,6 +1024,5 @@ bool ARMAsmPrinter::doFinalization(Module &M) {
     DW.EndModule();
   }
 
-  AsmPrinter::doFinalization(M);
-  return false; // success
+  return AsmPrinter::doFinalization(M);
 }

llvm/lib/Target/Alpha/AlphaAsmPrinter.cpp

@@ -198,8 +198,7 @@ bool AlphaAsmPrinter::doInitialization(Module &M)
   else
     O << "\t.arch ev6\n";
   O << "\t.set noat\n";
-  AsmPrinter::doInitialization(M);
-  return false;
+  return AsmPrinter::doInitialization(M);
 }
 
 bool AlphaAsmPrinter::doFinalization(Module &M) {
@@ -271,8 +270,7 @@ bool AlphaAsmPrinter::doFinalization(Module &M) {
     O << '\n';
   }
 
-  AsmPrinter::doFinalization(M);
-  return false;
+  return AsmPrinter::doFinalization(M);
 }
 
 /// PrintAsmOperand - Print out an operand for an inline asm expression.

llvm/lib/Target/IA64/IA64AsmPrinter.cpp

@@ -248,13 +248,13 @@ void IA64AsmPrinter::printMachineInstruction(const MachineInstr *MI) {
 }
 
 bool IA64AsmPrinter::doInitialization(Module &M) {
-  AsmPrinter::doInitialization(M);
+  bool Result = AsmPrinter::doInitialization(M);
 
   O << "\n.ident \"LLVM-ia64\"\n\n"
     << "\t.psr    lsb\n"  // should be "msb" on HP-UX, for starters
     << "\t.radix  C\n"
     << "\t.psr    abi64\n"; // we only support 64 bits for now
-  return false;
+  return Result;
 }
 
 bool IA64AsmPrinter::doFinalization(Module &M) {
@@ -344,8 +344,7 @@ bool IA64AsmPrinter::doFinalization(Module &M) {
   }
   O << "\n\n";
   
-  AsmPrinter::doFinalization(M);
-  return false; // success
+  return AsmPrinter::doFinalization(M);
 }
 
 /// createIA64CodePrinterPass - Returns a pass that prints the IA64

llvm/lib/Target/Mips/MipsAsmPrinter.cpp

@@ -428,6 +428,5 @@ doFinalization(Module &M)
     }
   }
 
-  AsmPrinter::doFinalization(M);
-  return false; // success
+  return AsmPrinter::doFinalization(M);
 }

llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp

@@ -626,7 +626,7 @@ bool LinuxAsmPrinter::runOnMachineFunction(MachineFunction &MF) {
 }
 
 bool LinuxAsmPrinter::doInitialization(Module &M) {
-  AsmPrinter::doInitialization(M);
+  bool Result = AsmPrinter::doInitialization(M);
   
   // GNU as handles section names wrapped in quotes
   Mang->setUseQuotes(true);
@@ -635,7 +635,7 @@ bool LinuxAsmPrinter::doInitialization(Module &M) {
   
   // Emit initial debug information.
   DW.BeginModule(&M);
-  return false;
+  return Result;
 }
 
 bool LinuxAsmPrinter::doFinalization(Module &M) {
@@ -743,8 +743,7 @@ bool LinuxAsmPrinter::doFinalization(Module &M) {
   // Emit initial debug information.
   DW.EndModule();
 
-  AsmPrinter::doFinalization(M);
-  return false; // success
+  return AsmPrinter::doFinalization(M);
 }
 
 std::string LinuxAsmPrinter::getSectionForFunction(const Function &F) const {
@@ -858,7 +857,7 @@ bool DarwinAsmPrinter::doInitialization(Module &M) {
   assert(Directive <= PPC::DIR_64 && "Directive out of range.");
   O << "\t.machine " << CPUDirectives[Directive] << "\n";
      
-  AsmPrinter::doInitialization(M);
+  bool Result = AsmPrinter::doInitialization(M);
   
   // Darwin wants symbols to be quoted if they have complex names.
   Mang->setUseQuotes(true);
@@ -878,7 +877,7 @@ bool DarwinAsmPrinter::doInitialization(Module &M) {
   
   // Emit initial debug information.
   DW.BeginModule(&M);
-  return false;
+  return Result;
 }
 
 bool DarwinAsmPrinter::doFinalization(Module &M) {
@@ -1078,8 +1077,7 @@ bool DarwinAsmPrinter::doFinalization(Module &M) {
   // code that does this, it is always safe to set.
   O << "\t.subsections_via_symbols\n";
 
-  AsmPrinter::doFinalization(M);
-  return false; // success
+  return AsmPrinter::doFinalization(M);
 }
 
 

llvm/lib/Target/Sparc/SparcAsmPrinter.cpp

@@ -286,6 +286,5 @@ bool SparcAsmPrinter::doFinalization(Module &M) {
       }
     }
 
-  AsmPrinter::doFinalization(M);
-  return false; // success
+  return AsmPrinter::doFinalization(M);
 }

llvm/lib/Target/X86/X86AsmPrinter.cpp

@@ -120,13 +120,13 @@ bool X86SharedAsmPrinter::doInitialization(Module &M) {
     DW.BeginModule(&M);
   }
 
-  AsmPrinter::doInitialization(M);
+  bool Result = AsmPrinter::doInitialization(M);
 
   // Darwin wants symbols to be quoted if they have complex names.
   if (Subtarget->isTargetDarwin())
     Mang->setUseQuotes(true);
 
-  return false;
+  return Result;
 }
 
 bool X86SharedAsmPrinter::doFinalization(Module &M) {
@@ -389,8 +389,7 @@ bool X86SharedAsmPrinter::doFinalization(Module &M) {
     DW.EndModule();
   }
 
-  AsmPrinter::doFinalization(M);
-  return false; // success
+  return AsmPrinter::doFinalization(M);
 }
 
 /// createX86CodePrinterPass - Returns a pass that prints the X86 assembly code

llvm/lib/Target/X86/X86IntelAsmPrinter.cpp

@@ -339,7 +339,7 @@ void X86IntelAsmPrinter::printMachineInstruction(const MachineInstr *MI) {
 }
 
 bool X86IntelAsmPrinter::doInitialization(Module &M) {
-  X86SharedAsmPrinter::doInitialization(M);
+  bool Result = X86SharedAsmPrinter::doInitialization(M);
   
   Mang->markCharUnacceptable('.');
 
@@ -373,7 +373,7 @@ bool X86IntelAsmPrinter::doInitialization(Module &M) {
     }
   }
 
-  return false;
+  return Result;
 }
 
 bool X86IntelAsmPrinter::doFinalization(Module &M) {
@@ -463,10 +463,10 @@ bool X86IntelAsmPrinter::doFinalization(Module &M) {
   }
   
   // Bypass X86SharedAsmPrinter::doFinalization().
-  AsmPrinter::doFinalization(M);
+  bool Result = AsmPrinter::doFinalization(M);
   SwitchToDataSection("");
   O << "\tend\n";
-  return false; // success
+  return Result;
 }
 
 void X86IntelAsmPrinter::EmitString(const ConstantArray *CVA) const {