maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Don't use a SmallSet for returned attribute inference 

Suggested post-commit by David Majnemer on IRC (following-up on a pre-commit
review comment).

llvm-svn: 275033
This commit is contained in:
Hal Finkel 2016-07-11 01:14:21 +00:00
parent 37bf71828b
commit ce881a41f9
1 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
llvm/lib/Transforms/IPO/FunctionAttrs.cpp
View File

@ -502,18 +502,26 @@ static bool addArgumentReturnedAttrs(const SCCNodeSet &SCCNodes) {
if (F->getReturnType()->isVoidTy())
continue;
SmallPtrSet<Value *, 2> RetArgs;
for (BasicBlock &BB : *F)
if (auto *Ret = dyn_cast<ReturnInst>(BB.getTerminator())) {
// Note that stripPointerCasts should look through functions with
// returned arguments.
Value *RetVal = Ret->getReturnValue()->stripPointerCasts();
if (RetVal->getType() == F->getReturnType() && isa<Argument>(RetVal))
RetArgs.insert(RetVal);
}
auto FindRetArg = [&]() -> Value * {
Value *RetArg = nullptr;
for (BasicBlock &BB : *F)
if (auto *Ret = dyn_cast<ReturnInst>(BB.getTerminator())) {
// Note that stripPointerCasts should look through functions with
// returned arguments.
Value *RetVal = Ret->getReturnValue()->stripPointerCasts();
if (RetVal->getType() == F->getReturnType() && isa<Argument>(RetVal)) {
if (!RetArg)
RetArg = RetVal;
else if (RetArg != RetVal)
return nullptr;
}
}
if (RetArgs.size() == 1) {
auto *A = cast<Argument>(*RetArgs.begin());
return RetArg;
};
if (Value *RetArg = FindRetArg()) {
auto *A = cast<Argument>(RetArg);
A->addAttr(AttributeSet::get(F->getContext(), A->getArgNo() + 1, B));
++NumReturned;
Changed = true;