diff --git a/lld/ELF/LinkerScript.cpp b/lld/ELF/LinkerScript.cpp index cb8a2b619c57..d7b0dc861d15 100644 --- a/lld/ELF/LinkerScript.cpp +++ b/lld/ELF/LinkerScript.cpp @@ -655,6 +655,17 @@ void LinkerScript::assignAddresses(std::vector> &Phdrs) { FirstPTLoad->First = Out::ElfHeader; if (!FirstPTLoad->Last) FirstPTLoad->Last = Out::ProgramHeaders; + } else if (!FirstPTLoad->First) { + // Sometimes the very first PT_LOAD segment can be empty. + // This happens if (all conditions met): + // - Linker script is used + // - First section in ELF image is not RO + // - Not enough space for program headers. + // The code below removes empty PT_LOAD segment and updates + // program headers size. + Phdrs.erase(FirstPTLoad); + Out::ProgramHeaders->setSize(sizeof(typename ELFT::Phdr) * + Phdrs.size()); } } diff --git a/lld/test/ELF/linkerscript/empty-load.s b/lld/test/ELF/linkerscript/empty-load.s new file mode 100644 index 000000000000..0a87d5727474 --- /dev/null +++ b/lld/test/ELF/linkerscript/empty-load.s @@ -0,0 +1,22 @@ +# REQUIRES: x86 +# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t +# RUN: echo "SECTIONS { .rw : { *(.rw) } .text : { *(.text) } }" > %t.script +# RUN: ld.lld -o %t1 --script %t.script %t +# RUN: llvm-objdump -private-headers %t1 | FileCheck %s + +## We expect 2 PT_LOAD segments +# CHECK: PHDR +# CHECK-NEXT: filesz {{0x[0-9a-f]+}} memsz {{0x[0-9a-f]+}} flags r-- +# CHECK-NEXT: LOAD +# CHECK-NEXT: filesz {{0x[0-9a-f]+}} memsz {{0x[0-9a-f]+}} flags rw- +# CHECK-NEXT: LOAD +# CHECK-NEXT: filesz {{0x[0-9a-f]+}} memsz {{0x[0-9a-f]+}} flags r-x +# CHECK-NEXT: STACK +# CHECK-NEXT: filesz + +.globl _start +_start: + jmp _start + +.section .rw, "aw" + .quad 0