maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Place undefined globals in .bss instead of .data 

Following up on the discussion from
http://lists.llvm.org/pipermail/llvm-dev/2017-April/112305.html, undef
values are now placed in the .bss as well as null values. This prevents
undef global values taking up potentially huge amounts of space in the
.data section.

The following two lines now both generate equivalent .bss data:

@vals1 = internal unnamed_addr global [20000000 x i32] zeroinitializer, align 4
@vals2 = internal unnamed_addr global [20000000 x i32] undef, align 4 ; previously unaccounted for

This is primarily motivated by the corresponding issue in the Rust
compiler (https://github.com/rust-lang/rust/issues/41315).

Differential Revision: https://reviews.llvm.org/D41705

Patch by varkor!

llvm-svn: 324424
This commit is contained in:
Eli Friedman 2018-02-06 23:22:14 +00:00
parent a3d37f0716
commit cd07a3e2f9
3 changed files with 30 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
llvm/lib/Target/TargetLoweringObjectFile.cpp
View File

@ -52,11 +52,24 @@ TargetLoweringObjectFile::~TargetLoweringObjectFile() {
delete Mang;
}
static bool isNullOrUndef(const Constant *C) {
// Check that the constant isn't all zeros or undefs.
if (C->isNullValue() || isa<UndefValue>(C))
return true;
if (!isa<ConstantAggregate>(C))
return false;
for (auto Operand : C->operand_values()) {
if (!isNullOrUndef(cast<Constant>(Operand)))
return false;
}
return true;
}
static bool isSuitableForBSS(const GlobalVariable *GV, bool NoZerosInBSS) {
const Constant *C = GV->getInitializer();
// Must have zero initializer.
if (!C->isNullValue())
if (!isNullOrUndef(C))
return false;
// Leave constant zeros in readonly constant sections, so they can be shared.

6
llvm/test/CodeGen/ARM/memfunc.ll
View File

@ -421,8 +421,10 @@ entry:
; CHECK: arr5:
; CHECK-NOT: .p2align
; CHECK: arr6:
; CHECK: .p2align 4
; CHECK: arr8:
; CHECK-IOS: arr8,128,4
; CHECK-DARWIN: arr8,128,4
; CHECK-EABI: arr8,128,16
; CHECK-GNUEABI: arr8,128,16
; CHECK: .p2align 4
; CHECK: arr9:

12
llvm/test/CodeGen/X86/undef-globals-bss.ll Normal file
View File

@ -0,0 +1,12 @@
; RUN: llc < %s | FileCheck %s
target triple = "x86_64-apple-darwin"
; CHECK: .zerofill __DATA,__bss,_vals,8000000,2 ## @vals
@vals = internal unnamed_addr global [2000000 x i32] undef, align 4
; CHECK: .zerofill __DATA,__bss,_struct,8000040,3 ## @struct
@struct = internal global { i1, [8000000 x i8], [7 x i8], i64, { [4 x i32], { i8 }, i1 } }
{ i1 false, [8000000 x i8] zeroinitializer, [7 x i8] undef, i64 0,
{ [4 x i32], { i8 }, i1 }
{ [4 x i32] zeroinitializer, { i8 } { i8 undef }, i1 false }
}, align 8