maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[BOLT] Remove --allow-stripped option 

AllowStripped has not been used in BOLT.
This option is replaced by actively detecting stripped binary.

Test Plan:

Reviewed By: Amir

Differential Revision: https://reviews.llvm.org/D130036
This commit is contained in:
Huan Nguyen 2022-07-28 23:15:20 -07:00 committed by Amir Ayupov
parent 986362d4a3
commit ccabbfff86
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
bolt/lib/Rewrite/RewriteInstance.cpp
View File

@ -92,12 +92,6 @@ cl::opt<std::string>
"output binary via bolt info section"), "output binary via bolt info section"),
cl::cat(BoltCategory)); cl::cat(BoltCategory));
cl::opt<bool>
AllowStripped("allow-stripped",
cl::desc("allow processing of stripped binaries"),
cl::Hidden,
cl::cat(BoltCategory));
cl::opt<bool> DumpDotAll( cl::opt<bool> DumpDotAll(
"dump-dot-all", "dump-dot-all",
cl::desc("dump function CFGs to graphviz format after each stage;" cl::desc("dump function CFGs to graphviz format after each stage;"
@ -2813,13 +2807,11 @@ void RewriteInstance::preprocessProfileData() {
if (Error E = ProfileReader->preprocessProfile(*BC.get())) if (Error E = ProfileReader->preprocessProfile(*BC.get()))
report_error("cannot pre-process profile", std::move(E)); report_error("cannot pre-process profile", std::move(E));
if (!BC->hasSymbolsWithFileName() && ProfileReader->hasLocalsWithFileName() && if (!BC->hasSymbolsWithFileName() && ProfileReader->hasLocalsWithFileName()) {
!opts::AllowStripped) {
errs() << "BOLT-ERROR: input binary does not have local file symbols " errs() << "BOLT-ERROR: input binary does not have local file symbols "
"but profile data includes function names with embedded file " "but profile data includes function names with embedded file "
"names. It appears that the input binary was stripped while a " "names. It appears that the input binary was stripped while a "
"profiled binary was not. If you know what you are doing and " "profiled binary was not\n";
"wish to proceed, use -allow-stripped option.\n";
exit(1); exit(1);
} }
} }