c++ IRGen. In trivial cases that object is going into static

storage and thus is implicitly zero-initialized, no need to
do C++11 memory model. This patch unconditionally detects
such condition and zeroinitializer's the variable.
Patch has been commented on and OKed by Doug off-line.
// rdar://12897704

llvm-svn: 172144
This commit is contained in:
Fariborz Jahanian 2013-01-10 23:28:43 +00:00
parent 098d7b76b0
commit cc7f008b85
2 changed files with 35 additions and 0 deletions

View File

@ -1006,6 +1006,23 @@ public:
llvm::Constant *CodeGenModule::EmitConstantInit(const VarDecl &D,
CodeGenFunction *CGF) {
// Make a quick check if variable can be default NULL initialized
// and avoid going through rest of code which may do, for c++11,
// initialization of memory to all NULLs.
if (!D.hasLocalStorage()) {
QualType Ty = D.getType();
if (Ty->isArrayType())
Ty = Context.getBaseElementType(Ty);
if (Ty->isRecordType())
if (const CXXConstructExpr *E =
dyn_cast_or_null<CXXConstructExpr>(D.getInit())) {
const CXXConstructorDecl *CD = E->getConstructor();
if (CD->isTrivial() && CD->isDefaultConstructor() &&
Ty->getAsCXXRecordDecl()->hasTrivialDestructor())
return EmitNullConstant(D.getType());
}
}
if (const APValue *Value = D.evaluateValue())
return EmitConstantValueForMemory(*Value, D.getType(), CGF);

View File

@ -0,0 +1,18 @@
// RUN: %clang_cc1 -S -emit-llvm -o %t.ll %s -triple x86_64-apple-darwin10
// RUN: %clang_cc1 -std=c++11 -S -emit-llvm -o %t-c++11.ll %s -triple x86_64-apple-darwin10
// RUN: diff %t.ll %t-c++11.ll
// rdar://12897704
struct sAFSearchPos {
unsigned char *pos;
unsigned char count;
};
static volatile struct sAFSearchPos testPositions;
static volatile struct sAFSearchPos arrayPositions[100][10][5];
int main() {
return testPositions.count + arrayPositions[10][4][3].count;
}