From cc0829f3cbb36612e11ddb8680a61c5be63f1a84 Mon Sep 17 00:00:00 2001 From: Xing GUO Date: Thu, 15 Nov 2018 11:51:13 +0000 Subject: [PATCH] [llvm-objdump] Use `auto` declaration in typecasting Summary: According to `MaskRay`, use `auto` for type inference, according to coding standards. Delete some comments, because these comments can be easily inferred from codes. Reviewers: jhenderson, MaskRay Reviewed By: jhenderson Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D54573 llvm-svn: 346946 --- llvm/tools/llvm-objdump/ELFDump.cpp | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/llvm/tools/llvm-objdump/ELFDump.cpp b/llvm/tools/llvm-objdump/ELFDump.cpp index 90289bab5d7b..b17a15a0d8fc 100644 --- a/llvm/tools/llvm-objdump/ELFDump.cpp +++ b/llvm/tools/llvm-objdump/ELFDump.cpp @@ -158,31 +158,23 @@ template void printProgramHeaders(const ELFFile *o) { } void llvm::printELFFileHeader(const object::ObjectFile *Obj) { - // Little-endian 32-bit - if (const ELF32LEObjectFile *ELFObj = dyn_cast(Obj)) + if (const auto *ELFObj = dyn_cast(Obj)) printProgramHeaders(ELFObj->getELFFile()); - // Big-endian 32-bit - else if (const ELF32BEObjectFile *ELFObj = dyn_cast(Obj)) + else if (const auto *ELFObj = dyn_cast(Obj)) printProgramHeaders(ELFObj->getELFFile()); - // Little-endian 64-bit - else if (const ELF64LEObjectFile *ELFObj = dyn_cast(Obj)) + else if (const auto *ELFObj = dyn_cast(Obj)) printProgramHeaders(ELFObj->getELFFile()); - // Big-endian 64-bit - else if (const ELF64BEObjectFile *ELFObj = dyn_cast(Obj)) + else if (const auto *ELFObj = dyn_cast(Obj)) printProgramHeaders(ELFObj->getELFFile()); } void llvm::printELFDynamicSection(const object::ObjectFile *Obj) { - // Little-endian 32-bit - if (const ELF32LEObjectFile *ELFObj = dyn_cast(Obj)) + if (const auto *ELFObj = dyn_cast(Obj)) printDynamicSection(ELFObj->getELFFile(), Obj->getFileName()); - // Big-endian 32-bit - else if (const ELF32BEObjectFile *ELFObj = dyn_cast(Obj)) + else if (const auto *ELFObj = dyn_cast(Obj)) printDynamicSection(ELFObj->getELFFile(), Obj->getFileName()); - // Little-endian 64-bit - else if (const ELF64LEObjectFile *ELFObj = dyn_cast(Obj)) + else if (const auto *ELFObj = dyn_cast(Obj)) printDynamicSection(ELFObj->getELFFile(), Obj->getFileName()); - // Big-endian 64-bit - else if (const ELF64BEObjectFile *ELFObj = dyn_cast(Obj)) + else if (const auto *ELFObj = dyn_cast(Obj)) printDynamicSection(ELFObj->getELFFile(), Obj->getFileName()); }