maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb] Make TestOptionValueFileColonLine work on Windows 

The colon in the file name is interpreted as a drive name and therefore
the path looks like foo:\\bar.c. Compare FileSpecs instead of their
string representation so we don't have to worry about that.
This commit is contained in:
Jonas Devlieghere 2020-07-20 23:13:01 -07:00
parent 7926143fb0
commit cb5926795a
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lldb/unittests/Interpreter/TestOptionValueFileColonLine.cpp
View File

@ -13,7 +13,7 @@
using namespace lldb_private; using namespace lldb_private;
void CheckSetting(const char *input, bool success, const char *path = nullptr, void CheckSetting(const char *input, bool success, FileSpec path = {},
uint32_t line_number = LLDB_INVALID_LINE_NUMBER, uint32_t line_number = LLDB_INVALID_LINE_NUMBER,
uint32_t column_number = LLDB_INVALID_COLUMN_NUMBER) { uint32_t column_number = LLDB_INVALID_COLUMN_NUMBER) {
@ -29,8 +29,7 @@ void CheckSetting(const char *input, bool success, const char *path = nullptr,
ASSERT_EQ(value.GetLineNumber(), line_number); ASSERT_EQ(value.GetLineNumber(), line_number);
ASSERT_EQ(value.GetColumnNumber(), column_number); ASSERT_EQ(value.GetColumnNumber(), column_number);
std::string value_path = value.GetFileSpec().GetPath(); ASSERT_EQ(value.GetFileSpec(), path);
ASSERT_STREQ(value_path.c_str(), path);
} }
TEST(OptionValueFileColonLine, setFromString) { TEST(OptionValueFileColonLine, setFromString) {
@ -48,11 +47,11 @@ TEST(OptionValueFileColonLine, setFromString) {
CheckSetting("foo.c", false); CheckSetting("foo.c", false);
// Now try with just a file & line: // Now try with just a file & line:
CheckSetting("foo.c:12", true, "foo.c", 12); CheckSetting("foo.c:12", true, FileSpec("foo.c"), 12);
CheckSetting("foo.c:12:20", true, "foo.c", 12, 20); CheckSetting("foo.c:12:20", true, FileSpec("foo.c"), 12, 20);
// Make sure a colon doesn't mess us up: // Make sure a colon doesn't mess us up:
CheckSetting("foo:bar.c:12", true, "foo:bar.c", 12); CheckSetting("foo:bar.c:12", true, FileSpec("foo:bar.c"), 12);
CheckSetting("foo:bar.c:12:20", true, "foo:bar.c", 12, 20); CheckSetting("foo:bar.c:12:20", true, FileSpec("foo:bar.c"), 12, 20);
// Try errors in the line number: // Try errors in the line number:
CheckSetting("foo.c:12c", false); CheckSetting("foo.c:12c", false);
CheckSetting("foo.c:12:20c", false); CheckSetting("foo.c:12:20c", false);