maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libc] Small adjustments to fenv tests 

Some libcs define non-standard FE_* macros and include them in
FE_ALL_EXCEPT. This change adjusts the fenv tests so that the
non-standard FE_* macros do not interfere when compiled with
fenv.h from another libc.

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D95650
This commit is contained in:
Michael Jones 2021-01-29 00:30:23 +00:00
parent c4d6f2707a
commit cb2e2d5068
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libc/test/src/fenv/enabled_exceptions_test.cpp
View File

@ -27,6 +27,12 @@ TEST(LlvmLibcExceptionStatusTest, RaiseAndCrash) {
int excepts[] = {FE_DIVBYZERO, FE_INVALID, FE_INEXACT, FE_OVERFLOW,
FE_UNDERFLOW};
// We '|' the individual exception flags instead of using FE_ALL_EXCEPT
// as it can include non-standard extensions. Note that we should be able
// to compile this file with headers from other libcs as well.
constexpr int allExcepts =
FE_DIVBYZERO | FE_INVALID | FE_INEXACT | FE_OVERFLOW | FE_UNDERFLOW;
for (int e : excepts) {
ASSERT_DEATH(
[=] {
@ -36,7 +42,7 @@ TEST(LlvmLibcExceptionStatusTest, RaiseAndCrash) {
// Raising all exceptions except |e| should not call the
// SIGFPE handler. They should set the exception flag though,
// so we verify that.
int others = FE_ALL_EXCEPT & ~e;
int others = allExcepts & ~e;
ASSERT_EQ(__llvm_libc::feraiseexcept(others), 0);
ASSERT_EQ(__llvm_libc::fetestexcept(others), others);

10
libc/test/src/fenv/exception_status_test.cpp
View File

@ -24,6 +24,10 @@ TEST(LlvmLibcExceptionStatusTest, RaiseAndTest) {
int excepts[] = {FE_DIVBYZERO, FE_INVALID, FE_INEXACT, FE_OVERFLOW,
FE_UNDERFLOW};
constexpr int allExcepts =
FE_DIVBYZERO | FE_INVALID | FE_INEXACT | FE_OVERFLOW | FE_UNDERFLOW;
for (int e : excepts) {
int r = __llvm_libc::feraiseexcept(e);
ASSERT_EQ(r, 0);
@ -108,8 +112,8 @@ TEST(LlvmLibcExceptionStatusTest, RaiseAndTest) {
}
}
int r = __llvm_libc::feraiseexcept(FE_ALL_EXCEPT);
int r = __llvm_libc::feraiseexcept(allExcepts);
ASSERT_EQ(r, 0);
int s = __llvm_libc::fetestexcept(FE_ALL_EXCEPT);
ASSERT_EQ(s, FE_ALL_EXCEPT);
int s = __llvm_libc::fetestexcept(allExcepts);
ASSERT_EQ(s, allExcepts);
}