maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[MLIR][NFC] Fix/update debug messages for analysis utils and affine fusion 

Drop trailing period in debug messages. Add an extra line for fusion
debug info.

Differential Revision: https://reviews.llvm.org/D79471
This commit is contained in:
Uday Bondhugula 2020-05-06 11:47:16 +05:30
parent 04bd2c37ca
commit ca09dab303
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
mlir/lib/Analysis/Utils.cpp
View File

@ -571,7 +571,7 @@ LogicalResult mlir::computeSliceUnion(ArrayRef<Operation *> opsA,
// Check if 'loopDepth' exceeds nesting depth of src/dst ops.
if ((!isBackwardSlice && loopDepth > getNestingDepth(opsA[i])) ||
(isBackwardSlice && loopDepth > getNestingDepth(opsB[j]))) {
LLVM_DEBUG(llvm::dbgs() << "Invalid loop depth\n.");
LLVM_DEBUG(llvm::dbgs() << "Invalid loop depth\n");
return failure();
}
@ -584,7 +584,7 @@ LogicalResult mlir::computeSliceUnion(ArrayRef<Operation *> opsA,
&dependenceConstraints, /*dependenceComponents=*/nullptr,
/*allowRAR=*/readReadAccesses);
if (result.value == DependenceResult::Failure) {
LLVM_DEBUG(llvm::dbgs() << "Dependence check failed\n.");
LLVM_DEBUG(llvm::dbgs() << "Dependence check failed\n");
return failure();
}
if (result.value == DependenceResult::NoDependence)
@ -601,7 +601,7 @@ LogicalResult mlir::computeSliceUnion(ArrayRef<Operation *> opsA,
// Initialize 'sliceUnionCst' with the bounds computed in previous step.
if (failed(tmpSliceState.getAsConstraints(&sliceUnionCst))) {
LLVM_DEBUG(llvm::dbgs()
<< "Unable to compute slice bound constraints\n.");
<< "Unable to compute slice bound constraints\n");
return failure();
}
assert(sliceUnionCst.getNumDimAndSymbolIds() > 0);
@ -612,7 +612,7 @@ LogicalResult mlir::computeSliceUnion(ArrayRef<Operation *> opsA,
FlatAffineConstraints tmpSliceCst;
if (failed(tmpSliceState.getAsConstraints(&tmpSliceCst))) {
LLVM_DEBUG(llvm::dbgs()
<< "Unable to compute slice bound constraints\n.");
<< "Unable to compute slice bound constraints\n");
return failure();
}
@ -645,8 +645,7 @@ LogicalResult mlir::computeSliceUnion(ArrayRef<Operation *> opsA,
tmpSliceCst.getNumLocalIds() > 0 ||
failed(sliceUnionCst.unionBoundingBox(tmpSliceCst))) {
LLVM_DEBUG(llvm::dbgs()
<< "Unable to compute union bounding box of slice bounds."
"\n.");
<< "Unable to compute union bounding box of slice bounds\n");
return failure();
}
}
@ -665,7 +664,7 @@ LogicalResult mlir::computeSliceUnion(ArrayRef<Operation *> opsA,
unsigned innermostCommonLoopDepth =
getInnermostCommonLoopDepth(ops, surroundingLoops);
if (loopDepth > innermostCommonLoopDepth) {
LLVM_DEBUG(llvm::dbgs() << "Exceeds max loop depth\n.");
LLVM_DEBUG(llvm::dbgs() << "Exceeds max loop depth\n");
return failure();
}

4
mlir/lib/Transforms/LoopFusion.cpp
View File

@ -1063,8 +1063,8 @@ static bool isFusionProfitable(Operation *srcOpInst, Operation *srcStoreOpInst,
unsigned *dstLoopDepth, bool maximalFusion,
double computeToleranceThreshold) {
LLVM_DEBUG({
llvm::dbgs() << "Checking whether fusion is profitable between:\n";
llvm::dbgs() << " " << *srcOpInst << " and \n";
llvm::dbgs() << "Checking whether fusion is profitable between src op:\n";
llvm::dbgs() << ' ' << *srcOpInst << " and destination op(s)\n";
for (auto dstOpInst : dstLoadOpInsts) {
llvm::dbgs() << " " << *dstOpInst << "\n";
};