From c9bd941f1fc7c4608f1e2433c182909ea90b35dd Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Wed, 9 May 2012 18:31:50 +0000 Subject: [PATCH] Fix -Wdelete-non-virtual-dtor in Tooling code. Also, add an anchor as per http://llvm.org/docs/CodingStandards.html#ll_virtual_anch llvm-svn: 156495 --- clang/include/clang/Tooling/ArgumentsAdjusters.h | 3 +++ clang/lib/Tooling/ArgumentsAdjusters.cpp | 3 +++ 2 files changed, 6 insertions(+) diff --git a/clang/include/clang/Tooling/ArgumentsAdjusters.h b/clang/include/clang/Tooling/ArgumentsAdjusters.h index 28d2a38a4c1a..492ddd2b0078 100644 --- a/clang/include/clang/Tooling/ArgumentsAdjusters.h +++ b/clang/include/clang/Tooling/ArgumentsAdjusters.h @@ -32,6 +32,7 @@ typedef std::vector CommandLineArguments; /// which is responsible for command line arguments modification before /// the arguments are used to run a frontend action. class ArgumentsAdjuster { + virtual void anchor(); public: /// \brief Returns adjusted command line arguments. /// @@ -39,6 +40,8 @@ public: /// /// \returns Modified sequence of command line arguments. virtual CommandLineArguments Adjust(const CommandLineArguments &Args) = 0; + virtual ~ArgumentsAdjuster() { + } }; /// \brief Syntax check only command line adjuster. diff --git a/clang/lib/Tooling/ArgumentsAdjusters.cpp b/clang/lib/Tooling/ArgumentsAdjusters.cpp index 73ad39816bf8..31dd46599587 100644 --- a/clang/lib/Tooling/ArgumentsAdjusters.cpp +++ b/clang/lib/Tooling/ArgumentsAdjusters.cpp @@ -17,6 +17,9 @@ namespace clang { namespace tooling { +void ArgumentsAdjuster::anchor() { +} + /// Add -fsyntax-only option to the commnand line arguments. CommandLineArguments ClangSyntaxOnlyAdjuster::Adjust(const CommandLineArguments &Args) {