Make instsimplify's analysis of icmp eq/ne use computeKnownBits to determine whether the icmp is always true or false. Patch by Suyog Sarda!

llvm-svn: 211251
This commit is contained in:
Nick Lewycky 2014-06-19 03:35:49 +00:00
parent 802df52424
commit c961030ac2
3 changed files with 39 additions and 1 deletions
llvm
lib/Analysis
test/Transforms
InstCombine
InstSimplify

View File

@ -2241,6 +2241,25 @@ static Value *SimplifyICmpInst(unsigned Predicate, Value *LHS, Value *RHS,
}
}
// If a bit is known to be zero for A and known to be one for B,
// then A and B cannot be equal.
if (ICmpInst::isEquality(Pred)) {
if (ConstantInt *CI = dyn_cast<ConstantInt>(RHS)) {
uint32_t BitWidth = CI->getBitWidth();
APInt LHSKnownZero(BitWidth, 0);
APInt LHSKnownOne(BitWidth, 0);
computeKnownBits(LHS, LHSKnownZero, LHSKnownOne);
APInt RHSKnownZero(BitWidth, 0);
APInt RHSKnownOne(BitWidth, 0);
computeKnownBits(RHS, RHSKnownZero, RHSKnownOne);
if (((LHSKnownOne & RHSKnownZero) != 0) ||
((LHSKnownZero & RHSKnownOne) != 0))
return (Pred == ICmpInst::ICMP_EQ)
? ConstantInt::getFalse(CI->getContext())
: ConstantInt::getTrue(CI->getContext());
}
}
// Special logic for binary operators.
BinaryOperator *LBO = dyn_cast<BinaryOperator>(LHS);
BinaryOperator *RBO = dyn_cast<BinaryOperator>(RHS);

View File

@ -31,7 +31,7 @@ bb1:
store <2 x double><double 0.0, double 0.0>, <2 x double>* %r, align 8
%indvar.next = add i64 %j, 2
%exitcond = icmp eq i64 %indvar.next, 557
%exitcond = icmp eq i64 %indvar.next, 556
br i1 %exitcond, label %bb11, label %bb1
bb11:

View File

@ -883,3 +883,22 @@ define i1 @returns_nonnull() {
; CHECK: ret i1 false
}
; If a bit is known to be zero for A and known to be one for B,
; then A and B cannot be equal.
define i1 @icmp_eq_const(i32 %a) nounwind {
%b = mul nsw i32 %a, -2
%c = icmp eq i32 %b, 1
ret i1 %c
; CHECK-LABEL: @icmp_eq_const
; CHECK-NEXT: ret i1 false
}
define i1 @icmp_ne_const(i32 %a) nounwind {
%b = mul nsw i32 %a, -2
%c = icmp ne i32 %b, 1
ret i1 %c
; CHECK-LABEL: @icmp_ne_const
; CHECK-NEXT: ret i1 true
}