maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clangd] Fix typo in symbol kind conversion 

Reviewers: hokein

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D70309
This commit is contained in:
Sam McCall 2019-11-15 15:46:17 +01:00
parent f018246c20
commit c9081968ea
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang-tools-extra/clangd/Protocol.cpp
View File

@ -257,7 +257,7 @@ SymbolKind indexSymbolKindToSymbolKind(index::SymbolKind Kind) {
return SymbolKind::Property;
case index::SymbolKind::Constructor:
case index::SymbolKind::Destructor:
return SymbolKind::Method;
return SymbolKind::Constructor;
case index::SymbolKind::ConversionFunction:
return SymbolKind::Function;
case index::SymbolKind::Parameter:

12
clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp
View File

@ -390,16 +390,16 @@ TEST_F(DocumentSymbolsTest, BasicSymbols) {
ElementsAreArray(
{AllOf(WithName("Foo"), WithKind(SymbolKind::Class), Children()),
AllOf(WithName("Foo"), WithKind(SymbolKind::Class),
Children(AllOf(WithName("Foo"), WithKind(SymbolKind::Method),
Children()),
AllOf(WithName("Foo"), WithKind(SymbolKind::Method),
Children()),
Children(AllOf(WithName("Foo"),
WithKind(SymbolKind::Constructor), Children()),
AllOf(WithName("Foo"),
WithKind(SymbolKind::Constructor), Children()),
AllOf(WithName("f"), WithKind(SymbolKind::Method),
Children()),
AllOf(WithName("operator="),
WithKind(SymbolKind::Method), Children()),
AllOf(WithName("~Foo"), WithKind(SymbolKind::Method),
Children()),
AllOf(WithName("~Foo"),
WithKind(SymbolKind::Constructor), Children()),
AllOf(WithName("Nested"), WithKind(SymbolKind::Class),
Children(AllOf(WithName("f"),
WithKind(SymbolKind::Method),

2
clang-tools-extra/clangd/unittests/XRefsTests.cpp
View File

@ -917,7 +917,7 @@ void foo())cpp";
HI.NamespaceScope = "";
HI.Name = "X";
HI.LocalScope = "X::"; // FIXME: Should be X<T *>::
HI.Kind = SymbolKind::Method; // FIXME: Should be Constructor
HI.Kind = SymbolKind::Constructor;
HI.Type = "void ()"; // FIXME: Should be None
HI.ReturnType = "void"; // FIXME: Should be None or X<T*>
HI.Definition = "X<type - parameter - 0 - 0 *>()"; // FIXME: --> X()