maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Cosmetic; don't use the magic constant 35 when HASH is more readable. This matches other MCK__<THING>_* usage better. 

Summary: No functional change. This fixes a magic constant in MCK__*_... macros only.

Reviewers: ostannard

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67840

llvm-svn: 372599
This commit is contained in:
Mark Murray 2019-09-23 12:52:42 +00:00
parent 0860934291
commit c720f63845
3 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
View File

@ -5535,43 +5535,43 @@ unsigned AArch64AsmParser::validateTargetOperandClass(MCParsedAsmOperand &AsmOp,
switch (Kind) {
default:
return Match_InvalidOperand;
case MCK__35_0:
case MCK__HASH_0:
ExpectedVal = 0;
break;
case MCK__35_1:
case MCK__HASH_1:
ExpectedVal = 1;
break;
case MCK__35_12:
case MCK__HASH_12:
ExpectedVal = 12;
break;
case MCK__35_16:
case MCK__HASH_16:
ExpectedVal = 16;
break;
case MCK__35_2:
case MCK__HASH_2:
ExpectedVal = 2;
break;
case MCK__35_24:
case MCK__HASH_24:
ExpectedVal = 24;
break;
case MCK__35_3:
case MCK__HASH_3:
ExpectedVal = 3;
break;
case MCK__35_32:
case MCK__HASH_32:
ExpectedVal = 32;
break;
case MCK__35_4:
case MCK__HASH_4:
ExpectedVal = 4;
break;
case MCK__35_48:
case MCK__HASH_48:
ExpectedVal = 48;
break;
case MCK__35_6:
case MCK__HASH_6:
ExpectedVal = 6;
break;
case MCK__35_64:
case MCK__HASH_64:
ExpectedVal = 64;
break;
case MCK__35_8:
case MCK__HASH_8:
ExpectedVal = 8;
break;
}

6
llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
View File

@ -11806,19 +11806,19 @@ unsigned ARMAsmParser::validateTargetOperandClass(MCParsedAsmOperand &AsmOp,
// immediate in the syntax.
switch (Kind) {
default: break;
case MCK__35_0:
case MCK__HASH_0:
if (Op.isImm())
if (const MCConstantExpr *CE = dyn_cast<MCConstantExpr>(Op.getImm()))
if (CE->getValue() == 0)
return Match_Success;
break;
case MCK__35_8:
case MCK__HASH_8:
if (Op.isImm())
if (const MCConstantExpr *CE = dyn_cast<MCConstantExpr>(Op.getImm()))
if (CE->getValue() == 8)
return Match_Success;
break;
case MCK__35_16:
case MCK__HASH_16:
if (Op.isImm())
if (const MCConstantExpr *CE = dyn_cast<MCConstantExpr>(Op.getImm()))
if (CE->getValue() == 16)

1
llvm/utils/TableGen/AsmMatcherEmitter.cpp
View File

@ -1111,6 +1111,7 @@ static std::string getEnumNameForToken(StringRef Str) {
case '<': Res += "_LT_"; break;
case '>': Res += "_GT_"; break;
case '-': Res += "_MINUS_"; break;
case '#': Res += "_HASH_"; break;
default:
if ((*it >= 'A' && *it <= 'Z') ||
(*it >= 'a' && *it <= 'z') ||