maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[flang] Correct obsolete comment in descriptor.h 

Original-commit: flang-compiler/f18@8ff52c493a
Reviewed-on: https://github.com/flang-compiler/f18/pull/683
Tree-same-pre-rewrite: false
This commit is contained in:
peter klausler 2019-08-28 09:14:46 -07:00
parent c236c83775
commit c71ba62c9f
2 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
flang/documentation/Calls.md
View File

@ -125,7 +125,7 @@ some design alternatives that are explored further below.
package them into single address (for calls to internal procedures & package them into single address (for calls to internal procedures &
for calls that pass internal procedures as arguments). for calls that pass internal procedures as arguments).
1. Resolve the target procedure's polymorphic binding, if any. 1. Resolve the target procedure's polymorphic binding, if any.
1. Marshal actual argument addresses/values into registers. 1. Marshal actual argument addresses (or values for `VALUE`/`%VAL()`) into registers.
1. Marshal an extra argument for the `CHARACTER` result 1. Marshal an extra argument for the `CHARACTER` result
length (assumed or explicit) or the function result descriptor. length (assumed or explicit) or the function result descriptor.
1. Set the "host instance" (static link) register when calling an internal 1. Set the "host instance" (static link) register when calling an internal
@ -187,15 +187,16 @@ argument.
First, actual arguments that are expressions, not designators, obviously First, actual arguments that are expressions, not designators, obviously
need to be computed and captured into memory in order to be passed need to be computed and captured into memory in order to be passed
by reference. by reference.
This includes parenthesized designators like `(X)` as an important This includes parenthesized designators like `(X)`, which are
special case, which are expressions in Fortran. expressions in Fortran, as an important special case.
(This case also technically includes constants, but those are better (This case also technically includes unparenthesized constants,
implemented by passing addresses in read-only memory when the interface but those are better implemented by passing addresses in read-only
is explicit.) memory.)
The dummy argument cannot be known to have `INTENT(OUT)` or The dummy argument cannot be known to have `INTENT(OUT)` or
`INTENT(IN OUT)`. `INTENT(IN OUT)`.
Small scalar or elemental `VALUE` arguments may be passed in registers. Small scalar or elemental `VALUE` arguments may be passed in registers,
as should arguments wrapped in the legacy VMS `%VAL()` notation.
Multiple elemental `VALUE` arguments might be packed into SIMD registers. Multiple elemental `VALUE` arguments might be packed into SIMD registers.
Actual arguments that are designators, not expressions, must also Actual arguments that are designators, not expressions, must also
@ -506,9 +507,9 @@ For examples: `Fa.mod.foo`, `Fa.mod.submod.foo`.
## Summary of checks to be enforced in semantics analysis ## Summary of checks to be enforced in semantics analysis
15.5.1 procedure references: 15.5.1 procedure references:
* C1533 (can't pass non-intrinsic `ELEMENTAL` as argument) * (C1533) can't pass non-intrinsic `ELEMENTAL` as argument
* C1536 alternate return labels must be in the inclusive scope * (C1536) alternate return labels must be in the inclusive scope
* C1537 coindexed argument cannot have a `POINTER` ultimate component * (C1537) coindexed argument cannot have a `POINTER` ultimate component
15.5.2.4 requirements for non-`POINTER` non-`ALLOCATABLE` dummies: 15.5.2.4 requirements for non-`POINTER` non-`ALLOCATABLE` dummies:
* (2) dummy must be monomorphic for coindexed polymorphic actual * (2) dummy must be monomorphic for coindexed polymorphic actual
@ -524,7 +525,7 @@ For examples: `Fa.mod.foo`, `Fa.mod.submod.foo`.
* (21) array sections with vector subscripts can't be passed to definable dummies * (21) array sections with vector subscripts can't be passed to definable dummies
(`INTENT(OUT)`, `INTENT(IN OUT)`, `ASYNCHRONOUS`, `VOLATILE`) (`INTENT(OUT)`, `INTENT(IN OUT)`, `ASYNCHRONOUS`, `VOLATILE`)
* (22) `VOLATILE` attributes must match when dummy has a coarray ultimate component * (22) `VOLATILE` attributes must match when dummy has a coarray ultimate component
* C1538 - C1540: checks for `ASYNCHRONOUS` and `VOLATILE` * (C1538 - C1540) checks for `ASYNCHRONOUS` and `VOLATILE`
15.5.2.5 requirements for `ALLOCATABLE` & `POINTER` arguments when both 15.5.2.5 requirements for `ALLOCATABLE` & `POINTER` arguments when both
the dummy and actual arguments have the same attributes: the dummy and actual arguments have the same attributes:
@ -540,8 +541,8 @@ the dummy and actual arguments have the same attributes:
* (7) `INTENT(OUT)` & `INTENT(IN OUT)` dummies require definable actuals * (7) `INTENT(OUT)` & `INTENT(IN OUT)` dummies require definable actuals
15.5.2.7 `POINTER` dummy arguments: 15.5.2.7 `POINTER` dummy arguments:
* C1541: `CONTIGUOUS` dummy requires simply contiguous actual * (C1541) `CONTIGUOUS` dummy requires simply contiguous actual
* C1542: actual argument cannot be coindexed unless procedure is intrinsic * (C1542) actual argument cannot be coindexed unless procedure is intrinsic
* (2) actual argument must be `POINTER` unless dummy is `INTENT(IN)` and * (2) actual argument must be `POINTER` unless dummy is `INTENT(IN)` and
actual could be the right-hand side of a pointer assignment statement actual could be the right-hand side of a pointer assignment statement
@ -575,7 +576,7 @@ For interoperable procedures and interfaces (18.3.6):
## Further topics to document ## Further topics to document
* Alternate return specifiers * Alternate return specifiers
* `%VAL()` and `%REF()` * `%VAL()`, `%REF()`, and `%DESCR()` legacy VMS interoperability extensions
* Unrestricted specific intrinsic functions as actual arguments * Unrestricted specific intrinsic functions as actual arguments
* SIMD variants of `ELEMENTAL` procedures (& unrestricted specific intrinsics) * SIMD variants of `ELEMENTAL` procedures (& unrestricted specific intrinsics)
* Elemental subroutine calls with array arguments * Elemental subroutine calls with array arguments

4
flang/runtime/descriptor.h
View File

@ -58,8 +58,8 @@ private:
// Descriptor (CFI_cdesc_t) generic descriptor. Space matters here, since // Descriptor (CFI_cdesc_t) generic descriptor. Space matters here, since
// descriptors serve as POINTER and ALLOCATABLE components of derived type // descriptors serve as POINTER and ALLOCATABLE components of derived type
// instances. The presence of this structure is implied by the flag // instances. The presence of this structure is implied by the flag
// (CFI_cdesc_t.extra & ADDENDUM) != 0, and the number of elements in // CFI_cdesc_t.f18Addendum, and the number of elements in the len_[]
// the len_[] array is determined by DerivedType::lenParameters(). // array is determined by DerivedType::lenParameters().
class DescriptorAddendum { class DescriptorAddendum {
public: public:
enum Flags { enum Flags {