maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fixed a thinko in the handling of the case where more than one thread had stopped with real stop reasons at the same time. 

Should be that if any of the threads wants to stop, we should stop.  The opposite was what was actually happening

<rdar://problem/12869725>

llvm-svn: 170153
This commit is contained in:
Jim Ingham 2012-12-13 22:24:15 +00:00
parent bf4b7be68e
commit c7078c228a
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lldb/source/Target/Process.cpp
View File

@ -3792,7 +3792,11 @@ Process::ProcessEventData::DoOnRemoval (Event *event_ptr)
for (idx = 0; idx < num_threads; ++idx) for (idx = 0; idx < num_threads; ++idx)
thread_index_array[idx] = curr_thread_list.GetThreadAtIndex(idx)->GetIndexID(); thread_index_array[idx] = curr_thread_list.GetThreadAtIndex(idx)->GetIndexID();
bool still_should_stop = true; // Use this to track whether we should continue from here. We will only continue the target running if
// no thread says we should stop. Of course if some thread's PerformAction actually sets the target running,
// then it doesn't matter what the other threads say...
bool still_should_stop = false;
for (idx = 0; idx < num_threads; ++idx) for (idx = 0; idx < num_threads; ++idx)
{ {
@ -3833,10 +3837,10 @@ Process::ProcessEventData::DoOnRemoval (Event *event_ptr)
SetRestarted (true); SetRestarted (true);
break; break;
} }
else if (!stop_info_sp->ShouldStop(event_ptr))
{ bool this_thread_wants_to_stop = stop_info_sp->ShouldStop(event_ptr);
still_should_stop = false; if (still_should_stop == false)
} still_should_stop = this_thread_wants_to_stop;
} }
} }