[WebAssembly] Add languages from debug info to producers section

Reviewers: aheejin, dschuff, sbc100

Subscribers: aprantl, jgravelle-google, hiraditya, sunfish

Differential Revision: https://reviews.llvm.org/D56889

llvm-svn: 351507
This commit is contained in:
Thomas Lively 2019-01-18 02:47:48 +00:00
parent f5ce42c040
commit c6795e07f0
5 changed files with 54 additions and 15 deletions

View File

@ -30,5 +30,5 @@ has_disassembler = 1
type = Library type = Library
name = WebAssemblyCodeGen name = WebAssemblyCodeGen
parent = WebAssembly parent = WebAssembly
required_libraries = Analysis AsmPrinter CodeGen Core MC Scalar SelectionDAG Support Target TransformUtils WebAssemblyAsmPrinter WebAssemblyDesc WebAssemblyInfo required_libraries = Analysis AsmPrinter BinaryFormat CodeGen Core MC Scalar SelectionDAG Support Target TransformUtils WebAssemblyAsmPrinter WebAssemblyDesc WebAssemblyInfo
add_to_library_groups = WebAssembly add_to_library_groups = WebAssembly

View File

@ -30,6 +30,7 @@
#include "llvm/CodeGen/MachineInstr.h" #include "llvm/CodeGen/MachineInstr.h"
#include "llvm/CodeGen/MachineModuleInfoImpls.h" #include "llvm/CodeGen/MachineModuleInfoImpls.h"
#include "llvm/IR/DataLayout.h" #include "llvm/IR/DataLayout.h"
#include "llvm/IR/DebugInfoMetadata.h"
#include "llvm/IR/GlobalVariable.h" #include "llvm/IR/GlobalVariable.h"
#include "llvm/MC/MCContext.h" #include "llvm/MC/MCContext.h"
#include "llvm/MC/MCSectionWasm.h" #include "llvm/MC/MCSectionWasm.h"
@ -148,31 +149,55 @@ void WebAssemblyAsmPrinter::EmitEndOfAsmFile(Module &M) {
} }
} }
EmitProducerInfo(M);
}
void WebAssemblyAsmPrinter::EmitProducerInfo(Module &M) {
llvm::SmallVector<std::pair<std::string, std::string>, 4> Languages;
if (const NamedMDNode *Debug = M.getNamedMetadata("llvm.dbg.cu")) {
llvm::SmallSet<StringRef, 4> SeenLanguages;
for (size_t i = 0, e = Debug->getNumOperands(); i < e; ++i) {
const auto *CU = cast<DICompileUnit>(Debug->getOperand(i));
StringRef Language = dwarf::LanguageString(CU->getSourceLanguage());
Language.consume_front("DW_LANG_");
if (SeenLanguages.insert(Language).second)
Languages.emplace_back(Language.str(), "");
}
}
llvm::SmallVector<std::pair<std::string, std::string>, 4> Tools;
if (const NamedMDNode *Ident = M.getNamedMetadata("llvm.ident")) { if (const NamedMDNode *Ident = M.getNamedMetadata("llvm.ident")) {
llvm::SmallSet<StringRef, 4> SeenTools; llvm::SmallSet<StringRef, 4> SeenTools;
llvm::SmallVector<std::pair<StringRef, StringRef>, 4> Tools;
for (size_t i = 0, e = Ident->getNumOperands(); i < e; ++i) { for (size_t i = 0, e = Ident->getNumOperands(); i < e; ++i) {
const auto *S = cast<MDString>(Ident->getOperand(i)->getOperand(0)); const auto *S = cast<MDString>(Ident->getOperand(i)->getOperand(0));
std::pair<StringRef, StringRef> Field = S->getString().split("version"); std::pair<StringRef, StringRef> Field = S->getString().split("version");
StringRef Name = Field.first.trim(); StringRef Name = Field.first.trim();
StringRef Version = Field.second.trim(); StringRef Version = Field.second.trim();
if (!SeenTools.insert(Name).second) if (SeenTools.insert(Name).second)
continue; Tools.emplace_back(Name.str(), Version.str());
Tools.emplace_back(Name, Version);
} }
}
int FieldCount = int(!Languages.empty()) + int(!Tools.empty());
if (FieldCount != 0) {
MCSectionWasm *Producers = OutContext.getWasmSection( MCSectionWasm *Producers = OutContext.getWasmSection(
".custom_section.producers", SectionKind::getMetadata()); ".custom_section.producers", SectionKind::getMetadata());
OutStreamer->PushSection(); OutStreamer->PushSection();
OutStreamer->SwitchSection(Producers); OutStreamer->SwitchSection(Producers);
OutStreamer->EmitULEB128IntValue(1); OutStreamer->EmitULEB128IntValue(FieldCount);
OutStreamer->EmitULEB128IntValue(strlen("processed-by")); for (auto &Producers : {std::make_pair("language", &Languages),
OutStreamer->EmitBytes("processed-by"); std::make_pair("processed-by", &Tools)}) {
OutStreamer->EmitULEB128IntValue(Tools.size()); if (Producers.second->empty())
for (auto &Tool : Tools) { continue;
OutStreamer->EmitULEB128IntValue(Tool.first.size()); OutStreamer->EmitULEB128IntValue(strlen(Producers.first));
OutStreamer->EmitBytes(Tool.first); OutStreamer->EmitBytes(Producers.first);
OutStreamer->EmitULEB128IntValue(Tool.second.size()); OutStreamer->EmitULEB128IntValue(Producers.second->size());
OutStreamer->EmitBytes(Tool.second); for (auto &Producer : *Producers.second) {
OutStreamer->EmitULEB128IntValue(Producer.first.size());
OutStreamer->EmitBytes(Producer.first);
OutStreamer->EmitULEB128IntValue(Producer.second.size());
OutStreamer->EmitBytes(Producer.second);
}
} }
OutStreamer->PopSection(); OutStreamer->PopSection();
} }

View File

@ -59,6 +59,7 @@ public:
//===------------------------------------------------------------------===// //===------------------------------------------------------------------===//
void EmitEndOfAsmFile(Module &M) override; void EmitEndOfAsmFile(Module &M) override;
void EmitProducerInfo(Module &M);
void EmitJumpTableInfo() override; void EmitJumpTableInfo() override;
void EmitConstantPool() override; void EmitConstantPool() override;
void EmitFunctionBodyStart() override; void EmitFunctionBodyStart() override;

View File

@ -13,6 +13,13 @@ target triple = "wasm32-unknown-unknown"
!llvm.ident = !{!3} !llvm.ident = !{!3}
!3 = !{!"clang version 123"} !3 = !{!"clang version 123"}
!llvm.module.flags = !{!4}
!4 = !{i32 2, !"Debug Info Version", i32 3}
!llvm.dbg.cu = !{!5}
!5 = distinct !DICompileUnit(language: DW_LANG_C99, file: !6)
!6 = !DIFile(filename: "test", directory: "testdir")
; CHECK: .section .custom_section.red,"",@ ; CHECK: .section .custom_section.red,"",@
; CHECK-NEXT: .ascii "foo" ; CHECK-NEXT: .ascii "foo"
@ -23,7 +30,13 @@ target triple = "wasm32-unknown-unknown"
; CHECK-NEXT: .ascii "qux" ; CHECK-NEXT: .ascii "qux"
; CHECK: .section .custom_section.producers,"",@ ; CHECK: .section .custom_section.producers,"",@
; CHECK-NEXT: .int8 2
; CHECK-NEXT: .int8 8
; CHECK-NEXT: .ascii "language"
; CHECK-NEXT: .int8 1 ; CHECK-NEXT: .int8 1
; CHECK-NEXT: .int8 3
; CHECK-NEXT: .ascii "C99"
; CHECK-NEXT: .int8 0
; CHECK-NEXT: .int8 12 ; CHECK-NEXT: .int8 12
; CHECK-NEXT: .ascii "processed-by" ; CHECK-NEXT: .ascii "processed-by"
; CHECK-NEXT: .int8 1 ; CHECK-NEXT: .int8 1

View File

@ -126,7 +126,7 @@
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-NEXT: Section { ; CHECK-NEXT: Section {
; CHECK-NEXT: Type: CUSTOM (0x0) ; CHECK-NEXT: Type: CUSTOM (0x0)
; CHECK-NEXT: Size: 62 ; CHECK-NEXT: Size: 77
; CHECK-NEXT: Offset: 1021 ; CHECK-NEXT: Offset: 1021
; CHECK-NEXT: Name: producers ; CHECK-NEXT: Name: producers
; CHECK-NEXT: } ; CHECK-NEXT: }