maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ELF] - X86_64: don't allow 8/16 bit dynamic relocations. 

Having 8/16 bits dynamic relocations is incorrect.

Both gold and bfd (built from latest sources) disallow
that too.

Differential revision: https://reviews.llvm.org/D45158

llvm-svn: 329059
This commit is contained in:
George Rimar 2018-04-03 11:58:23 +00:00
parent 624e163f53
commit c6735c23d2
2 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lld/ELF/Arch/X86_64.cpp
View File

@ -156,8 +156,9 @@ void X86_64<ELFT>::writePlt(uint8_t *Buf, uint64_t GotPltEntryAddr,
}
template <class ELFT> bool X86_64<ELFT>::isPicRel(RelType Type) const {
return Type != R_X86_64_PC32 && Type != R_X86_64_32 &&
Type != R_X86_64_TPOFF32;
return Type != R_X86_64_8 && Type != R_X86_64_PC8 && Type != R_X86_64_16 &&
Type != R_X86_64_PC16 && Type != R_X86_64_32 &&
Type != R_X86_64_PC32 && Type != R_X86_64_TPOFF32;
}
template <class ELFT>

16
lld/test/ELF/x86-64-dyn-rel-error3.s Normal file
View File

@ -0,0 +1,16 @@
# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
# RUN: not ld.lld %t.o -shared -o %t.so 2>&1 | FileCheck %s
# CHECK: relocation R_X86_64_8 cannot be used against symbol foo; recompile with -fPIC
# CHECK: relocation R_X86_64_16 cannot be used against symbol foo; recompile with -fPIC
# CHECK: relocation R_X86_64_PC8 cannot be used against symbol foo; recompile with -fPIC
# CHECK: relocation R_X86_64_PC16 cannot be used against symbol foo; recompile with -fPIC
.global foo
.data
.byte foo # R_X86_64_8
.short foo # R_X86_64_16
.byte foo - . # R_X86_64_PC8
.short foo - . # R_X86_64_PC16