maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[DAGCombiner] Slightly improve readability of matchRotateSub 

Slightly change the wording in the function comment. Originally, it can be
misunderstood as we turned the input into two subsequent rotates.

Better connect the comment which talks about Mask and the code which used
LoBits.  Renamed variable to MaskLoBits.

llvm-svn: 203314
This commit is contained in:
Adam Nemet 2014-03-07 23:56:24 +00:00
parent 95a90099fa
commit c6553a8354
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
View File

@ -3414,9 +3414,9 @@ static bool MatchRotateHalf(SDValue Op, SDValue &Shift, SDValue &Mask) {
// //
// (or (shift1 X, Neg), (shift2 X, Pos)) // (or (shift1 X, Neg), (shift2 X, Pos))
// //
// reduces to a rotate in direction shift2 by Pos and a rotate in direction // reduces to a rotate in direction shift2 by Pos or (equivalently) a rotate
// shift1 by Neg. The range [0, OpSize) means that we only need to consider // in direction shift1 by Neg. The range [0, OpSize) means that we only need
// shift amounts with defined behavior. // to consider shift amounts with defined behavior.
static bool matchRotateSub(SDValue Pos, SDValue Neg, unsigned OpSize) { static bool matchRotateSub(SDValue Pos, SDValue Neg, unsigned OpSize) {
// If OpSize is a power of 2 then: // If OpSize is a power of 2 then:
// //
@ -3437,7 +3437,7 @@ static bool matchRotateSub(SDValue Pos, SDValue Neg, unsigned OpSize) {
// //
// for all Neg and Pos. Note that the (or ...) then invokes undefined // for all Neg and Pos. Note that the (or ...) then invokes undefined
// behavior if Pos == 0 (and consequently Neg == OpSize). // behavior if Pos == 0 (and consequently Neg == OpSize).
// //
// We could actually use [A] whenever OpSize is a power of 2, but the // We could actually use [A] whenever OpSize is a power of 2, but the
// only extra cases that it would match are those uninteresting ones // only extra cases that it would match are those uninteresting ones
// where Neg and Pos are never in range at the same time. E.g. for // where Neg and Pos are never in range at the same time. E.g. for
@ -3449,13 +3449,13 @@ static bool matchRotateSub(SDValue Pos, SDValue Neg, unsigned OpSize) {
// always invokes undefined behavior for 32-bit X. // always invokes undefined behavior for 32-bit X.
// //
// Below, Mask == OpSize - 1 when using [A] and is all-ones otherwise. // Below, Mask == OpSize - 1 when using [A] and is all-ones otherwise.
unsigned LoBits = 0; unsigned MaskLoBits = 0;
if (Neg.getOpcode() == ISD::AND && if (Neg.getOpcode() == ISD::AND &&
isPowerOf2_64(OpSize) && isPowerOf2_64(OpSize) &&
Neg.getOperand(1).getOpcode() == ISD::Constant && Neg.getOperand(1).getOpcode() == ISD::Constant &&
cast<ConstantSDNode>(Neg.getOperand(1))->getAPIntValue() == OpSize - 1) { cast<ConstantSDNode>(Neg.getOperand(1))->getAPIntValue() == OpSize - 1) {
Neg = Neg.getOperand(0); Neg = Neg.getOperand(0);
LoBits = Log2_64(OpSize); MaskLoBits = Log2_64(OpSize);
} }
// Check whether Neg has the form (sub NegC, NegOp1) for some NegC and NegOp1. // Check whether Neg has the form (sub NegC, NegOp1) for some NegC and NegOp1.
@ -3496,8 +3496,9 @@ static bool matchRotateSub(SDValue Pos, SDValue Neg, unsigned OpSize) {
return false; return false;
// Now we just need to check that OpSize & Mask == Width & Mask. // Now we just need to check that OpSize & Mask == Width & Mask.
if (LoBits) if (MaskLoBits)
return Width.getLoBits(LoBits) == 0; // Opsize & Mask is 0 since Mask is Opsize - 1.
return Width.getLoBits(MaskLoBits) == 0;
return Width == OpSize; return Width == OpSize;
} }