maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Formatters] Temporarily disable libc++ std::function formatter due to performance issue 

Summary: We have been seeing increased reports of performance issue around large project and formatting std::function variables especially in functions signatures in back traces. There are some possible fixes but exploring those fixes may take time and it is better to temporarily disable the formatter due to its impact and re-enable it once we have a fix.

Differential Revision: https://reviews.llvm.org/D65666

llvm-svn: 367701
This commit is contained in:
Shafik Yaghmour 2019-08-02 18:16:04 +00:00
parent e4c46c34ce
commit c5d4014535
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py
View File

@ -21,6 +21,9 @@ class LibCxxFunctionTestCase(TestBase):
var.SetPreferSyntheticValue(True) var.SetPreferSyntheticValue(True)
return var return var
# Temporarily skipping for everywhere b/c we are disabling the std::function formatter
# due to performance issues but plan on turning it back on once they are addressed.
@skipIf
@add_test_categories(["libc++"]) @add_test_categories(["libc++"])
def test(self): def test(self):
"""Test that std::function as defined by libc++ is correctly printed by LLDB""" """Test that std::function as defined by libc++ is correctly printed by LLDB"""

6
lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
View File

@ -566,12 +566,6 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
ConstString("^(std::__[[:alnum:]]+::)weak_ptr<.+>(( )?&)?$"), ConstString("^(std::__[[:alnum:]]+::)weak_ptr<.+>(( )?&)?$"),
stl_synth_flags, true); stl_synth_flags, true);
AddCXXSummary(
cpp_category_sp, lldb_private::formatters::LibcxxFunctionSummaryProvider,
"libc++ std::function summary provider",
ConstString("^std::__[[:alnum:]]+::function<.+>$"), stl_summary_flags,
true);
stl_summary_flags.SetDontShowChildren(false); stl_summary_flags.SetDontShowChildren(false);
stl_summary_flags.SetSkipPointers(false); stl_summary_flags.SetSkipPointers(false);
AddCXXSummary(cpp_category_sp, AddCXXSummary(cpp_category_sp,